-
Notifications
You must be signed in to change notification settings - Fork 253
fix: removed isCompact dependency from Export button visibility #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
prafullaAtSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add version related changes for this release.
Code changes are good to go ahead.
Will approve after version changes will get added to elements for release.
prafullaAtSB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go ahead..
Please update the release version changes also with this PR changes, so that it can be released directly.
Issue Description
Root Cause
The "isCompact" hook detects narrow viewports and is used as a condition to hide the export button.
When isCompact is true (small screen), the button is removed from the DOM, making it unavailable to users who need it most.
Solution Implemented