Add Content-Type and Accept headers where necessary

[provokateurin]

Closes #1798

[netlify]

✅ Deploy Preview for stoplight-elements ready!

Name	Link
🔨 Latest commit	5916c3d
🔍 Latest deploy log	https://app.netlify.com/sites/stoplight-elements/deploys/64390496b6e27c0008645389
😎 Deploy Preview	https://deploy-preview-2349--stoplight-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for stoplight-elements-demo ready!

Name	Link
🔨 Latest commit	5916c3d
🔍 Latest deploy log	https://app.netlify.com/sites/stoplight-elements-demo/deploys/6439049665517700086f3d0a
😎 Deploy Preview	https://deploy-preview-2349--stoplight-elements-demo.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[mnaumanali94]

I think this should also close #2351

[dotslashderek]

Very nice and appreciated - yes @mnaumanali94 I do think this will fix the other issue as well - @provokateurin I think the test failures are pretty straightforward to fix, take a look at my comment and thanks for contributing!

[provokateurin]

@dotslashderek Tests don't seem to run?

[dotslashderek]

@provokateurin yeah - we're trying to figure out what's going on with the CircleCI pipeline. I pushed a couple changes to trigger runs, then fixed the four TryIt failures. If you want to take a look at the HttpOperation test that's failing, I'd like to see what happens with the pipeline when you push a new commit. Otherwise no worries I'll take another look at this in the next day or two. Thanks again!

[provokateurin]

@dotslashderek I dropped your changes because I made a mistake with the Accept header where it still added it with 0 accepted mime types. Afterwards your fixes for the tests were breaking it again, so I did it properly. Tests work locally now.

[dotslashderek]

One comment, but a second request - could you add a couple quick unit tests around getAcceptedMimeTypes (that's why I exported it in the suggestion) to build-request.spec.ts? - could be as simple as:

describe('getAcceptedMimeTypes', () => {
    const operationSingleResponse: IHttpOperation = {
      id: 'adsf',
      method: 'GET',
      path: '/a/path',
      responses: [
        {
          id: 'responseA',
          code: '200',
          contents: [
            {
              id: 'adsf',
              mediaType: 'application/json',
            },
            {
              id: 'dfvs',
              mediaType: 'application/json',
            },
            {
              id: 'aaaa',
              mediaType: 'multipart/form-data',
            },
          ],
        },
      ],
    };

    const operationMultipleResponses: IHttpOperation = {
      id: 'sfdf',
      method: 'POST',
      path: '/a/nother/path',
      responses: [
        {
          id: 'responseA',
          code: '200',
          contents: [
            {
              id: 'adsf',
              mediaType: 'application/json',
            },
            {
              id: 'dfvs',
              mediaType: 'application/json',
            },
          ],
        },
        {
          id: 'responseB',
          code: '200',
          contents: [
            {
              id: 'adsf',
              mediaType: 'application/json',
            },
            {
              id: 'dfvs',
              mediaType: 'multipart/form-data',
            },
          ],
        },
        {
          id: 'responseC',
          code: '200',
          contents: [
            {
              id: 'dfvs',
              mediaType: 'multipart/form-data',
            },
          ],
        },
        {
          id: 'responseB',
          code: '200',
          contents: [
            {
              id: 'adsf',
              mediaType: 'text/json',
            },
            {
              id: 'dfvs',
              mediaType: 'multipart/form-data',
            },
          ],
        },
      ],
    };

    it('Handles a single response with duplicates', () => {
      expect(getAcceptedMimeTypes(operationSingleResponse)).toStrictEqual(['application/json', 'multipart/form-data']);
    });

    it('Handles multiple responses and dedups appropriately', () => {
      expect(getAcceptedMimeTypes(operationMultipleResponses)).toStrictEqual([
        'application/json',
        'multipart/form-data',
        'text/json',
      ]);
    });
  });

Thanks! (And for fixing things properly w/ the TryIt tests 🙂 )

[provokateurin]

@dotslashderek Added the tests

[dotslashderek]

Looks good @provokateurin - thanks for taking care of this!

[provokateurin]

Missing reviews or ready to merge?

[dotslashderek]

Missing reviews or ready to merge?

Ready to merge!

[provokateurin]

Thanks a lot!