Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust to Ajv 8 #2

Merged
merged 1 commit into from
Apr 21, 2021
Merged

feat: adjust to Ajv 8 #2

merged 1 commit into from
Apr 21, 2021

Conversation

P0lip
Copy link

@P0lip P0lip commented Apr 21, 2021 •
edited
Loading

The first puzzle of https://github.com/stoplightio/platform-internal/issues/5792
needed by stoplightio/spectral#1302

The change is rather minor - we had to change dataPath to instancePath

@P0lip P0lip added the enhancement New feature or request label Apr 21, 2021
@P0lip P0lip self-assigned this Apr 21, 2021
@P0lip P0lip requested review from a team and paulatulis and removed request for a team April 21, 2021 14:17
paulatulis
paulatulis approved these changes Apr 21, 2021
View reviewed changes
Copy link

@paulatulis paulatulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I can verify that this works until it is merged and in prod, but looks like the tests pass, and so I will go ahead and approve. LMK if I should yalc this or anything to get a better sense of things.

@P0lip
Copy link
Author

P0lip commented Apr 21, 2021

Unfortunately this cannot be yalced yet.
I'd need to implement the Spectral part of the whole task, but I haven't managed to do so yet.

@P0lip P0lip merged commit b7d0909 into master Apr 21, 2021
@P0lip P0lip deleted the ajv-8 branch April 21, 2021 20:18
P0lip added a commit that referenced this pull request Apr 26, 2021
@P0lip
feat: adjust to Ajv 8 (#2)
f3bb80a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulatulis paulatulis paulatulis approved these changes

Assignees

@P0lip P0lip

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P0lip @paulatulis