-
-
Notifications
You must be signed in to change notification settings - Fork 350
feat: Add legal page with configuration options #724
Conversation
also again same as in #721, i changed the config, using |
Thank you for the good approach. To the questions. Data protection and imprint are two separate things that must be accessed separately. Strictly speaking, both must be accessible with their own link. The placement on the website is almost irrelevant. According to the law, it must be quick and easy to find and accessible with a maximum of two clicks. So it can be in a hamburger menu, for example. On implementation: |
That looks very good. Great. Where can we see it afterwards on the main page? |
That's a really nice implementation, especially with markdown, thank you :) Regarding where to place the links, you could add a footer. In the past there was already a footer but I've removed it in this commit c52a4d5. You could add it back but replace the text "Made with 🖤 Elias Schneider" with "Powered by Pingvin Share" (or do you have a better idea?). And then place the two privacy policy and imprint links on the right side. What do you think about that? Regarding your other PRs, I really appreciate it but I currently have much going on so it might take some time until I've reviewed them, sorry. |
Test it immediately if it is in the official docker image. |
Would also close #335 I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I've noticed the following things that I would change:
- There is probably something wrong with the z-index of the footer because it's in front of the toasts and the backdrop of the dialogs:
- I would remove the GitHub logo and directly link to the GitHub repository if you click "Pocket ID" in the footer because the page that you've linked is just the docs page.
- I would mention in the description of the imprint and privacy policy that markdown is supported.
oh the hint about markdown must have been lost when i separated privacy and imprint |
I've just improved the footer for mobile and now it can be merged. Thank you :) |
closes #591
Allows you to enable a page with legal information which you can customize.
Only issue I have: I wanted to put the link in the footer - there is no footer in this project. Any ideas where to put the link instead? I was thinking of the home page, but that can be disabled and is not accessible for users that are logged in.
@ipod86 I guess you know a bit more about this, can you say if this would be enough to make it compliant with applicable laws (when a link to the page is placed somewhere)? Should something be changed? Should legal notice and privacy policy be separated or something like that?