Skip to content
This repository was archived by the owner on Jun 29, 2025. It is now read-only.

Conversation

aarondoet
Copy link
Contributor

closes #591

Allows you to enable a page with legal information which you can customize.

Only issue I have: I wanted to put the link in the footer - there is no footer in this project. Any ideas where to put the link instead? I was thinking of the home page, but that can be disabled and is not accessible for users that are logged in.

@ipod86 I guess you know a bit more about this, can you say if this would be enough to make it compliant with applicable laws (when a link to the page is placed somewhere)? Should something be changed? Should legal notice and privacy policy be separated or something like that?

config

legal page

@aarondoet
Copy link
Contributor Author

also again same as in #721, i changed the config, using npx prisma db seed updates it correctly but idk if a new migration is necessary nonetheless.

@ipod86
Copy link

ipod86 commented Dec 30, 2024

Thank you for the good approach.

To the questions. Data protection and imprint are two separate things that must be accessed separately. Strictly speaking, both must be accessible with their own link.

The placement on the website is almost irrelevant. According to the law, it must be quick and easy to find and accessible with a maximum of two clicks. So it can be in a hamburger menu, for example.

On implementation:
I think it's good to be able to enter the text yourself. However, it would be very practical to have the choice between free text and a link. Our data protection declaration is a PDF with over 10 pages. You can also put a link to the imprint and data protection on the main website.

@aarondoet
Copy link
Contributor Author

Thanks for the input! I have updated it to have a text input and a url input. If a URL is provided the link (which I still have not placed anywhere yet) will be to that URL, otherwise it will show the provided content. I also split it up into imprint and privacy policy.

config

imprint

privacy policy

imprint

@ipod86
Copy link

ipod86 commented Dec 30, 2024

That looks very good. Great. Where can we see it afterwards on the main page?

@stonith404
Copy link
Owner

That's a really nice implementation, especially with markdown, thank you :)

Regarding where to place the links, you could add a footer. In the past there was already a footer but I've removed it in this commit c52a4d5. You could add it back but replace the text "Made with 🖤 Elias Schneider" with "Powered by Pingvin Share" (or do you have a better idea?). And then place the two privacy policy and imprint links on the right side.

What do you think about that?

Regarding your other PRs, I really appreciate it but I currently have much going on so it might take some time until I've reviewed them, sorry.

@aarondoet
Copy link
Contributor Author

aarondoet commented Dec 30, 2024

Added a footer now. Has imprint and privacy policy on the left (if they exist), link to the project github io page in the middle (no i18n rn) and link to github repo on the right.

footer

footer

@aarondoet aarondoet marked this pull request as ready for review December 30, 2024 09:50
@ipod86
Copy link

ipod86 commented Dec 30, 2024

Test it immediately if it is in the official docker image.

@aarondoet
Copy link
Contributor Author

Would also close #335 I think

Copy link
Owner

@stonith404 stonith404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I've noticed the following things that I would change:

  1. There is probably something wrong with the z-index of the footer because it's in front of the toasts and the backdrop of the dialogs:

Toasts:
image
Backdrop:
image

  1. I would remove the GitHub logo and directly link to the GitHub repository if you click "Pocket ID" in the footer because the page that you've linked is just the docs page.
  2. I would mention in the description of the imprint and privacy policy that markdown is supported.

@aarondoet
Copy link
Contributor Author

oh the hint about markdown must have been lost when i separated privacy and imprint

@aarondoet aarondoet requested a review from stonith404 December 31, 2024 11:09
@stonith404
Copy link
Owner

I've just improved the footer for mobile and now it can be merged. Thank you :)

@stonith404 stonith404 merged commit df1ffaa into stonith404:main Jan 2, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Legal notice and data protection
3 participants