-
Notifications
You must be signed in to change notification settings - Fork 17
Fixed The skills button not showing up #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… to original state
and made most strings that were like val + " " + val be $"{val} {val}"
|
also probly should ping u as you seem to not be active on this proj for a good bit now @stoneman2 so yee |
|
note from what i can tell v1.4.0 doesnt really have the Loot value work im pretty sure but thats not my job to fix lul |
|
in the meantime i guess ill just upload a fixed version of the current mod as it seems you aint responding |
|
so i fixed it all i will update my pr later but for now ill upload it to thunderstore contact me @CatsArmy on discord when u want me to take it down or ill just remove it when you update the mod |
|
This is very cool, I will handle this soon when I'm not bombarded with college |
|
|
The save system isn't working too well, steamids aren't getting fetched properly, I can't test any of it alone |
|
Hi I tried CatArmy patched mod but when i dropped a loot in the ship I was unable to switch between item and I got this error : [Info : Unity Log] bool val: True [Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target. |
But did that error effect the skill menu? |
1 similar comment
But did that error effect the skill menu? |
Modlist only this mod Here a full run from start to the bug happening and a pic from the menu. |
|
Ok I suspect it may be the fact that I'm doing it to 1.4.x and 1.3.2 or something like that which as of rn 1.4 is really out I just forked it for the sake of fixing the menu I will probably just update the mod to revert to 1.3.21 with my patch with it or something idk |

fixes #59
the issue was like so
When the mods listed in #59 were installed they added too many buttons before the resume button that you were using as the base for the position of the > skills button so i just changed it to be with the position of the Exp bar instead
so pretty much what was going on was hmm a lot of buttons go brr you were hmm idc vroom and the button was never seen on screen again. (because the Y level of the resume button was too high so it was off screen)
optimizes some strings to be $"{val} {otherVal}" instead of val + " " + otherVal
makes the Exp bar clickable to enter the skills menu
side effects are that i moved the other elements of the exp bar aka Profits and Level into a Container object to hold them for an easy way to anchor the position of the skills button and stuff and also making the text not clickable and only the exp bar thing and its outline(it also has a thing for when u hover over it very pog I didn't even make it was already there lul).
Refactors some code and by mistake auto formatted some stuff that had been weirdly formatted by you.
so I'm not gonna clean that back to how it was you can clean that up I'm not doing that much lul