Skip to content

Conversation

@CatsArmy
Copy link

fixes #59

the issue was like so
When the mods listed in #59 were installed they added too many buttons before the resume button that you were using as the base for the position of the > skills button so i just changed it to be with the position of the Exp bar instead
so pretty much what was going on was hmm a lot of buttons go brr you were hmm idc vroom and the button was never seen on screen again. (because the Y level of the resume button was too high so it was off screen)

optimizes some strings to be $"{val} {otherVal}" instead of val + " " + otherVal

makes the Exp bar clickable to enter the skills menu

side effects are that i moved the other elements of the exp bar aka Profits and Level into a Container object to hold them for an easy way to anchor the position of the skills button and stuff and also making the text not clickable and only the exp bar thing and its outline(it also has a thing for when u hover over it very pog I didn't even make it was already there lul).

Refactors some code and by mistake auto formatted some stuff that had been weirdly formatted by you.

so I'm not gonna clean that back to how it was you can clean that up I'm not doing that much lul

@CatsArmy
Copy link
Author

also probly should ping u as you seem to not be active on this proj for a good bit now @stoneman2 so yee

@CatsArmy
Copy link
Author

note from what i can tell v1.4.0 doesnt really have the Loot value work im pretty sure but thats not my job to fix lul

@CatsArmy
Copy link
Author

CatsArmy commented Feb 2, 2024

in the meantime i guess ill just upload a fixed version of the current mod as it seems you aint responding

@CatsArmy
Copy link
Author

CatsArmy commented Feb 2, 2024

so i fixed it all i will update my pr later but for now ill upload it to thunderstore contact me @CatsArmy on discord when u want me to take it down or ill just remove it when you update the mod

@stoneman2
Copy link
Owner

This is very cool, I will handle this soon when I'm not bombarded with college

@CatsArmy
Copy link
Author

CatsArmy commented Feb 6, 2024

  • O Pog I'm working on a save system update too as I'm sometimes getting a error

@stoneman2
Copy link
Owner

The save system isn't working too well, steamids aren't getting fetched properly, I can't test any of it alone

@KillerTankHUN
Copy link

Hi

I tried CatArmy patched mod but when i dropped a loot in the ship I was unable to switch between item and I got this error :

[Info : Unity Log] bool val: True
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Warning: Unity Log] PlayOneShot was called with a null AudioClip.
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Error : Unity Log] ArgumentException: The Object you want to instantiate is null.
Stack trace:
UnityEngine.Object.Instantiate[T] (T original) (at :0)
LethalProgression.Patches.HUDManagerPatch.MakeBar () (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.ShowXPUpdate (System.Int32 oldXP, System.Int32 newXP, System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.XPHUDUpdate_ClientRPC (System.Int32 oldXP, System.Int32 newXP, System.Int32 xpGained) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.AddXPServerRPC (System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.GiveXPForScrap (GrabbableObject GObject) (at <178eafc43f8f404bae6484784e8df889>:0)
(wrapper dynamic-method) HUDManager.DMDHUDManager::AddNewScrapFoundToDisplay(HUDManager,GrabbableObject)
RoundManager.CollectNewScrapForThisRound (GrabbableObject scrapObject) (at :0)
GameNetcodeStuff.PlayerControllerB.SetItemInElevator (System.Boolean droppedInShipRoom, System.Boolean droppedInElevator, GrabbableObject gObject) (at :0)
AudioReverbTrigger.ChangeAudioReverbForPlayer (GameNetcodeStuff.PlayerControllerB pScript) (at :0)
AudioReverbTrigger.OnTriggerStay (UnityEngine.Collider other) (at :0)

[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] PLAYER OPENED MENU

@CatsArmy
Copy link
Author

Hi

I tried CatArmy patched mod but when i dropped a loot in the ship I was unable to switch between item and I got this error :

[Info : Unity Log] bool val: True
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Warning: Unity Log] PlayOneShot was called with a null AudioClip.
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Error : Unity Log] ArgumentException: The Object you want to instantiate is null.
Stack trace:
UnityEngine.Object.Instantiate[T] (T original) (at :0)
LethalProgression.Patches.HUDManagerPatch.MakeBar () (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.ShowXPUpdate (System.Int32 oldXP, System.Int32 newXP, System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.XPHUDUpdate_ClientRPC (System.Int32 oldXP, System.Int32 newXP, System.Int32 xpGained) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.AddXPServerRPC (System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.GiveXPForScrap (GrabbableObject GObject) (at <178eafc43f8f404bae6484784e8df889>:0)
(wrapper dynamic-method) HUDManager.DMDHUDManager::AddNewScrapFoundToDisplay(HUDManager,GrabbableObject)
RoundManager.CollectNewScrapForThisRound (GrabbableObject scrapObject) (at :0)
GameNetcodeStuff.PlayerControllerB.SetItemInElevator (System.Boolean droppedInShipRoom, System.Boolean droppedInElevator, GrabbableObject gObject) (at :0)
AudioReverbTrigger.ChangeAudioReverbForPlayer (GameNetcodeStuff.PlayerControllerB pScript) (at :0)
AudioReverbTrigger.OnTriggerStay (UnityEngine.Collider other) (at :0)

[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] PLAYER OPENED MENU

But did that error effect the skill menu?
Modlist
Need more info

1 similar comment
@CatsArmy
Copy link
Author

Hi

I tried CatArmy patched mod but when i dropped a loot in the ship I was unable to switch between item and I got this error :

[Info : Unity Log] bool val: True
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Info : Unity Log] playerHeldBy on currentlyGrabbingObject 1: Player (GameNetcodeStuff.PlayerControllerB)
[Warning: Unity Log] PlayOneShot was called with a null AudioClip.
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Warning: Unity Log] NetworkVariable is written to, but doesn't know its NetworkBehaviour yet. Are you modifying a NetworkVariable before the NetworkObject is spawned?
[Error : Unity Log] ArgumentException: The Object you want to instantiate is null.
Stack trace:
UnityEngine.Object.Instantiate[T] (T original) (at :0)
LethalProgression.Patches.HUDManagerPatch.MakeBar () (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.ShowXPUpdate (System.Int32 oldXP, System.Int32 newXP, System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.XPHUDUpdate_ClientRPC (System.Int32 oldXP, System.Int32 newXP, System.Int32 xpGained) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.LC_XP.AddXPServerRPC (System.Int32 xp) (at <178eafc43f8f404bae6484784e8df889>:0)
LethalProgression.Patches.HUDManagerPatch.GiveXPForScrap (GrabbableObject GObject) (at <178eafc43f8f404bae6484784e8df889>:0)
(wrapper dynamic-method) HUDManager.DMDHUDManager::AddNewScrapFoundToDisplay(HUDManager,GrabbableObject)
RoundManager.CollectNewScrapForThisRound (GrabbableObject scrapObject) (at :0)
GameNetcodeStuff.PlayerControllerB.SetItemInElevator (System.Boolean droppedInShipRoom, System.Boolean droppedInElevator, GrabbableObject gObject) (at :0)
AudioReverbTrigger.ChangeAudioReverbForPlayer (GameNetcodeStuff.PlayerControllerB pScript) (at :0)
AudioReverbTrigger.OnTriggerStay (UnityEngine.Collider other) (at :0)

[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Warning: Unity Log] Audio source failed to initialize audio spatializer. An audio spatializer is specified in the audio project settings, but the associated plugin was not found or initialized properly. Please make sure that the selected spatializer is compatible with the target.
[Info : Unity Log] PLAYER OPENED MENU

But did that error effect the skill menu?
Modlist
Need more info

@KillerTankHUN
Copy link

But did that error effect the skill menu? Modlist Need more info

Modlist only this mod
and it depends how the mod should work if you get a lvl up when you get the necessary xp the yes.
Skill
Lethal.txt

Here a full run from start to the bug happening and a pic from the menu.

@CatsArmy
Copy link
Author

Ok I suspect it may be the fact that I'm doing it to 1.4.x and 1.3.2 or something like that which as of rn 1.4 is really out I just forked it for the sake of fixing the menu I will probably just update the mod to revert to 1.3.21 with my patch with it or something idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Skills button wont show up

3 participants