Add closeEventCallback to expose the websocket CloseEvent so that the #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks all good, I will merge it. Will it be possible to add to docs. If not I will add those. Many thanks! |
|
Hi Deepak, Thanks for the quick response and for keeping this library updated. I'll add something to the docs. |
|
One step I have missed in Contribut.md - before committing your next change set, please run I will update the documentation later. |
dillon-sellars
force-pushed
the
feature/closeEvent
branch
2 times, most recently
from
9580252 to
1074cb4
Compare
consumer of this library can make decisions on `CloseEvent.code` and other properties of the CloseEvent. Cleanup _parseConnect code
dillon-sellars
force-pushed
the
feature/closeEvent
branch
from
1074cb4 to
dd529f6
Compare
|
Updated -- also took a stab at cleaning up |
|
Great! |
|
Planning for next version of stompjs is on the way. Your participation will be really appreciated, please join at stomp-js/stompjs#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I need to access the websocket CloseEvent and do things like
if (closeEvent.code === 1008).... This PR adds an closeEventHandler that passes along the CloseEvent from the@ws.onclosehandler.