-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade v0.29.0 #47
Upgrade v0.29.0 #47
Conversation
Signed-off-by: Matej Gera <matejgera@gmail.com>
Fix the compact test's by running this sub-test sequentially. The further steps depend on this test's results so it's wrong to run it as a sub-test. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* return store info only when the service is ready Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix test Signed-off-by: Ben Ye <ben.ye@bytedance.com>
* Cut 0.25.0-rc.0 (thanos-io#5184) Signed-off-by: Matej Gera <matejgera@gmail.com> * Cut v0.25.0 (thanos-io#5209) Signed-off-by: Matej Gera <matejgera@gmail.com> * Create v0.25.1 built with Go 1.17.8 (thanos-io#5226) The binaries published with this release are built with Go1.17.8 to avoid [CVE-2022-24921](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-24921). Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> * *: Cut 0.25.2 rc.0 (thanos-io#5247) * fix: add null check to exemplar data (thanos-io#5202) Signed-off-by: Thomas Mota <tmm@danskecommodities.com> * Ruler: Fix WAL directory in stateless mode (thanos-io#5242) Signed-off-by: Matej Gera <matejgera@gmail.com> * Update CHANGELOG, VERSION Signed-off-by: Matej Gera <matejgera@gmail.com> * Updates busybox SHA (thanos-io#5234) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: yeya24 <yeya24@users.noreply.github.com> Co-authored-by: Tomás Mota <tomasrebelomota@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yeya24 <yeya24@users.noreply.github.com> * Cut v0.25.2 Signed-off-by: Matej Gera <matejgera@gmail.com> Update tutorials Signed-off-by: Matej Gera <matejgera@gmail.com> Co-authored-by: Matthias Loibl <mail@matthiasloibl.com> Co-authored-by: Tomás Mota <tomasrebelomota@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yeya24 <yeya24@users.noreply.github.com>
With the current GRPC APIs, layering Thanos Queriers results in the root querier getting all of the samples and executing the query in memory. As a result, the intermediary Queriers do not do any intensive work and merely transport samples from the Stores to the root Querier. When data is perfectly sharded, users can implement a pattern where the root Querier instructs the intermediary ones to execute the queries from their stores and return back results. The results can then be concatenated by the root querier and returned to the user. In order to support this use case, this commit implements a GRPC API in the Querier which is analogous to the HTTP Query API exposed by Prometheus. Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
…stination dir (thanos-io#5229) * Change error cleanup in objstore.DownloadDir to delete files not directories Dst is always a directory. If any file after the first fails to download, the cleanup will fail because the destination already contains at least one file. This commit changes the cleanup logic to clean up successfully downloaded files one by one instead of attempting to clean up the whole dst directory. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add cleanup of root dst directory. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Add unit test for cleanup of DownloadDir Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Fix linter Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Guilherme Souza <101073+guilhermef@users.noreply.github.com>
…anos-io#5269) Plus better explanation. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Pierre Hanselmann <pierre.hanselmann@gmail.com>
* Fix miekgdns resolver to work with CNAME records too Signed-off-by: Marco Pracucci <marco@pracucci.com> * Remove unused context Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/discovery/dns/miekgdns/resolver.go Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Lucas Servén Marín <lserven@gmail.com> Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
* remove old ui Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * add changelog Signed-off-by: Augustin Husson <husson.augustin@gmail.com> * update assets Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: yeya24 <yeya24@users.noreply.github.com>
…hanos-io#5274) Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.2. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.2) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: fix Ian Billett's GitHub handle I noticed that CI was failing [0] for PR thanos-io#5284 because Ian had changed his GitHub handle from @ianbillett to @bill3tt. This commit fixes this. [0] https://github.com/thanos-io/thanos/runs/6050355497?check_suite_focus=true#step:5:135 Signed-off-by: Lucas Servén Marín <lserven@gmail.com> * docs: fix broken links to GitHub docs Currently, documentation generation is failing because mdox can't fetch some GitHub documentation pages since the URLs for the help content has changed. This commit updates the links to use the correct URLs. Signed-off-by: Lucas Servén Marín <lserven@gmail.com> * MAINTAINERS.md: regenerate Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
* refactor global window typings Use declaration merging for better window types Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * bump vulnerable react-scripts version Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Signed-off-by: claude ebaneck <claudeforlife@gmail.com> Co-authored-by: claude ebaneck <claude.ebaneck@vestiairecollective.com>
A recent commit (thanos-io#5250) added a GRPC API to Thanos Query which allows executing PromQL over GRPC. This API is currently not discoverable through endpointsets which makes it hard for other Thanos components to use it. This commit extends endpointsets with a GetQueryAPIClients method which returns Query API clients to all components which support this API. Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
* Added support for ppc64le Signed-off-by: Marvin Giessing <marvin.giessing@gmail.com> * Updated Changelog Signed-off-by: Marvin Giessing <marvin.giessing@gmail.com> * Updated promu & protoc Signed-off-by: Marvin Giessing <marvin.giessing@gmail.com> * Updated Makefile comment Signed-off-by: Marvin Giessing <marvin.giessing@gmail.com>
Attempted to repro thanos-io#5257, but no good luck. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
…hanos-io#5281) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
* query-frontend: Added repro for dedup affecting precision of querying. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * QFE does not cache request with dedup=false. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Move info about queries that skip cache logic to docs Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Update CHANGELOG Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Run docs formatter Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> * Fix e2e tests where caching logic is desired Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: Pedro Araujo <pedro.araujo@saltpay.co>
…hanos-io#5301) Use the doWithBatch function to avoid starting goroutines to fetch batched results from memcached before they are allowed to run via the concurrency Gate. This avoids starting many goroutines which cannot make any progress due to a concurrency limit. Fixes thanos-io#4967 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Co-authored-by: Wiard van Rij <wvanrij@roku.com>
Signed-off-by: Wiard van Rij <wvanrij@roku.com> Co-authored-by: Wiard van Rij <wvanrij@roku.com>
Signed-off-by: Wiard van Rij <wvanrij@roku.com> Co-authored-by: Wiard van Rij <wvanrij@roku.com>
Signed-off-by: jmjf <jamee.mikell@gmail.com>
623aa40
to
40dcb2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngraham20: 1 invalid OWNERS file
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@@ -4,6 +4,12 @@ approvers: | |||
- dislbenn | |||
- marcolan018 | |||
- subbarao-meduri | |||
<<<<<<< HEAD | |||
- dislbenn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot parse file: error converting YAML to JSON: yaml: line 8: could not find expected ':'.
Signed-off-by: Nathaniel Graham <ngraham@redhat.com>
Signed-off-by: Nathaniel Graham <ngraham@redhat.com>
/retest |
1 similar comment
/retest |
Signed-off-by: Nathaniel Graham <ngraham@redhat.com>
Signed-off-by: Nathaniel Graham <ngraham@redhat.com>
/test sonar-pre-submit |
42bfaab
to
9657957
Compare
Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
9657957
to
3028e5d
Compare
/retest |
1 similar comment
/retest |
/override ci/prow/sonar-pre-submit |
@ngraham20: ngraham20 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanos image worked as expected in testing, and the sonar-pre-submit can be debugged at a later point. Overriding for now. |
/override ci/prow/sonar-pre-submit Overriding the |
@dislbenn: Overrode contexts on behalf of dislbenn: ci/prow/sonar-pre-submit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn, ngraham20 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.