Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert placementrule CRD apiversion to v1beta1 for supporting <4.5 v… #301

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

xiangjingli
Copy link
Contributor

…ersions of OCP

Signed-off-by: Xiangjing Li xiangli@redhat.com

The apiVersion of the kind:CustomResourceDefinition in all of our CRDs has to be v1beta1 for backporting <4.5 versions of OCP. Or the CRD will fail to be applied to OCP <4.5. OCP 4.4 is still supported by ACM.

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition

Please note our appsub CRDs version are still remained as V1

apiVersion: apps.open-cluster-management.io/v1
kind: Subscription

…ersions of OCP

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@ianzhang366
Copy link
Contributor

@xiangjingli

since you are modifying the CRD, can you please add the following to the print column

#273 (comment)

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
@xiangjingli
Copy link
Contributor Author

xiangjingli commented Sep 28, 2020

@ianzhang366

since you are modifying the CRD, can you please add the following to the print column
#273 (comment)

Just checked the #273 PR, Some of them have been in the master trunk. Also the CRD can' be generated directly now by controller-gen, as it generates CRDs with V1. We have to convert it to v1beta1 for OCP < 4.5 backport.

So the new diff only merged the new print columns and the markdown comments in types.go

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianzhang366, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiangjingli xiangjingli merged commit ae2be1e into master Sep 28, 2020
@xiangjingli xiangjingli deleted the crdv1beta1 branch September 28, 2020 16:29
magic-mirror-bot bot pushed a commit that referenced this pull request Dec 19, 2022
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Update multicloud-operators-channel go.mod version

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
(cherry picked from commit 263d518)
lennysgarage added a commit that referenced this pull request Dec 19, 2022
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Update multicloud-operators-channel go.mod version

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
(cherry picked from commit 263d518)

Co-authored-by: Jonathan Marcantonio <jmarcant@redhat.com>
dhaiducek pushed a commit to dhaiducek/multicloud-operators-subscription that referenced this pull request Oct 17, 2024
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Update multicloud-operators-channel go.mod version

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>

Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants