-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert placementrule CRD apiversion to v1beta1 for supporting <4.5 v… #301
Conversation
…ersions of OCP Signed-off-by: Xiangjing Li <xiangli@redhat.com>
since you are modifying the CRD, can you please add the following to the print column |
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
Just checked the #273 PR, Some of them have been in the master trunk. Also the CRD can' be generated directly now by controller-gen, as it generates CRDs with V1. We have to convert it to v1beta1 for OCP < 4.5 backport. So the new diff only merged the new print columns and the markdown comments in types.go |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ianzhang366, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Update multicloud-operators-channel go.mod version Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> (cherry picked from commit 263d518)
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Update multicloud-operators-channel go.mod version Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> (cherry picked from commit 263d518) Co-authored-by: Jonathan Marcantonio <jmarcant@redhat.com>
Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Update multicloud-operators-channel go.mod version Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com> Signed-off-by: Jonathan Marcantonio <jmarcant@redhat.com>
…ersions of OCP
Signed-off-by: Xiangjing Li xiangli@redhat.com
The apiVersion of the
kind:CustomResourceDefinition
in all of our CRDs has to bev1beta1
for backporting <4.5 versions of OCP. Or the CRD will fail to be applied to OCP <4.5. OCP 4.4 is still supported by ACM.Please note our appsub CRDs version are still remained as V1