Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #408 #1122

Merged
merged 1 commit into from
Jul 30, 2024
Merged

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #408 #1122

merged 1 commit into from
Jul 30, 2024

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

@magic-mirror-bot magic-mirror-bot bot commented Jul 29, 2024 •
edited
Loading

@xiangjingli
avoid error status accumulation when failing to fetch hub channel (#408)
34cdc67 
Signed-off-by: Xiangjing Li <xiangli@redhat.com>
(cherry picked from commit 90b7a75)
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign chenz4027 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@magic-mirror-bot magic-mirror-bot bot mentioned this pull request Jul 29, 2024
Closed
@xiangjingli
Copy link
Contributor

/test test-unit

1 similar comment
@xiangjingli
Copy link
Contributor

/test test-unit

@magic-mirror-bot magic-mirror-bot bot closed this Jul 30, 2024
@mikeshng mikeshng reopened this Jul 30, 2024
@mikeshng mikeshng requested review from xiangjingli and removed request for jnpacker and chenz4027 July 30, 2024 01:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@xiangjingli
Copy link
Contributor

/test test-unit

@xiangjingli xiangjingli merged commit 519c66a into main Jul 30, 2024
11 of 12 checks passed
@xiangjingli xiangjingli deleted the magic-mirror-main-1722296683342 branch July 30, 2024 02:04
xiangjingli added a commit that referenced this pull request Jul 30, 2024
@magic-mirror-bot @xiangjingli
avoid error status accumulation when failing to fetch hub channel (#408…
06fd4f8 
…) (#1122)

Signed-off-by: Xiangjing Li <xiangli@redhat.com>
(cherry picked from commit 90b7a75)

Co-authored-by: Xiangjing Li <55890329+xiangjingli@users.noreply.github.com>
@xiangjingli xiangjingli mentioned this pull request Jul 30, 2024
Merged
1 task
xiangjingli added a commit that referenced this pull request Jul 30, 2024
@xiangjingli @magic-mirror-bot
avoid error status accumulation when failing to fetch hub channel (#408…
c97cc9f 
…) (#1122) (#1124)

(cherry picked from commit 90b7a75)

Co-authored-by: magic-mirror-bot[bot] <107957005+magic-mirror-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjingli xiangjingli Awaiting requested review from xiangjingli

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #408
2 participants
@xiangjingli @mikeshng