Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-framework-addon: #135 #371

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

magic-mirror-bot[bot]
Copy link

Since the controller no longer restarts when the Gatekeeper installation
state changes, we need to prevent controller-runtime from creating a
watch on constraint templates, or else the client-go watcher will
continuously log errors trying to restart the watch.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit a74d55e)
Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link

mprahl commented Apr 22, 2024

/cherry-pick release-2.10

@openshift-cherrypick-robot

@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarcloud bot commented Apr 22, 2024

@magic-mirror-bot magic-mirror-bot bot merged commit b208cce into main Apr 22, 2024
13 of 14 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1713797610848 branch April 22, 2024 15:18
@openshift-cherrypick-robot

@mprahl: new pull request created: #372

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants