Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple policies per namespace by using different key in policy #21

Merged
merged 1 commit into from
May 14, 2020

Conversation

gparvin
Copy link
Contributor

@gparvin gparvin commented Apr 24, 2020

Issue https://github.com/open-cluster-management/backlog/issues/1905 shows that multiple policies looking for expired certs in the same namespace causes a conflict which this PR will resolve.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gparvin gparvin self-assigned this May 13, 2020
@gparvin gparvin requested a review from tphee May 13, 2020 20:35
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gparvin, tphee
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gparvin gparvin merged commit ff994d6 into master May 14, 2020
@gparvin gparvin deleted the fix-namespace-map branch May 14, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants