Split logic of NoiseModule into different files #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
November 5, 2019 11:42
* Removed jQuery * Created eq node * Created convolver node * Created analyser * Created noiseRadio node * Created KingTubby node * Fixed delay values * Fixed css * Fixed css * Added wraper for slider with description * Added more slider wrapers * Created liveinput * Fixed ui and css * Fixed ui and css * Created recorder ver2 * Changed some properties access * Fixed noise module * Created and used extend method for options * Code clean up * Replaced old jQuery code * Start audioContext on button click * Minor fixes * Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also split all node implementations into different files and try to split visualization from implementation