Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript #322

Merged
merged 22 commits into from
Nov 27, 2019
Merged

TypeScript #322

merged 22 commits into from
Nov 27, 2019

Conversation

stoically
Copy link
Owner

@stoically stoically commented Nov 10, 2019

Why

  • Codebase grows and staying maintainable gets harder, TS arguably makes it easier
  • Better contracts between Background and UI

Evaluation

Transpiler

tsc

  • typechecking and transpiling from the same lib
  • official
  • no babel plugins

babel-plugin-transform-typescript

  • no type checking, must be done with tsc
  • not official
  • supports plugins

Linting

Bundling

Workarounds

UI

Decisions

  • Linting: typescript-eslint and tsc
  • Bundling: parcel1 with tsc

Todo

  • Background
  • UI
  • Tests

@stoically stoically changed the title Typescript TypeScript Nov 10, 2019
@stoically stoically force-pushed the typescript branch 4 times, most recently from ecefea2 to 9e7a3ef Compare November 11, 2019 09:04
@stoically stoically force-pushed the typescript branch 2 times, most recently from 083cda0 to c04ef52 Compare November 26, 2019 16:28
@stoically stoically marked this pull request as ready for review November 27, 2019 14:01
@stoically stoically merged commit ebbda5f into master Nov 27, 2019
@stoically stoically deleted the typescript branch November 27, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant