Adds contracts for byte_add, byte_sub and byte_offset #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also adds proofs verifying unit, int and composite types.
xsxszab
reviewed
Nov 15, 2024
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| #[cfg_attr( | ||
| bootstrap, | ||
| rustc_const_stable(feature = "ptr_metadata_const", since = "1.83.0") | ||
| )] |
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -277,7 +285,11 @@ impl<T: ?Sized> *mut T { | |||
| pub const unsafe fn as_ref<'a>(self) -> Option<&'a T> { | |||
| // SAFETY: the caller must guarantee that `self` is valid for a | |||
| // reference if it isn't null. | |||
| if self.is_null() { None } else { unsafe { Some(&*self) } } | |||
| if self.is_null() { | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -352,7 +364,11 @@ impl<T: ?Sized> *mut T { | |||
| { | |||
| // SAFETY: the caller must guarantee that `self` meets all the | |||
| // requirements for a reference. | |||
| if self.is_null() { None } else { Some(unsafe { &*(self as *const MaybeUninit<T>) }) } | |||
| if self.is_null() { | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -537,7 +569,9 @@ impl<T: ?Sized> *mut T { | |||
| #[stable(feature = "pointer_byte_offsets", since = "1.75.0")] | |||
| #[rustc_const_stable(feature = "const_pointer_byte_offsets", since = "1.75.0")] | |||
| pub const fn wrapping_byte_offset(self, count: isize) -> Self { | |||
| self.cast::<u8>().wrapping_offset(count).with_metadata_of(self) | |||
| self.cast::<u8>() | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -578,7 +612,9 @@ impl<T: ?Sized> *mut T { | |||
| #[must_use = "returns a new pointer rather than modifying its argument"] | |||
| #[inline(always)] | |||
| pub fn mask(self, mask: usize) -> *mut T { | |||
| intrinsics::ptr_mask(self.cast::<()>(), mask).cast_mut().with_metadata_of(self) | |||
| intrinsics::ptr_mask(self.cast::<()>(), mask) | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -628,7 +664,11 @@ impl<T: ?Sized> *mut T { | |||
| pub const unsafe fn as_mut<'a>(self) -> Option<&'a mut T> { | |||
| // SAFETY: the caller must guarantee that `self` is be valid for | |||
| // a mutable reference if it isn't null. | |||
| if self.is_null() { None } else { unsafe { Some(&mut *self) } } | |||
| if self.is_null() { | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
xsxszab
reviewed
Nov 15, 2024
library/core/src/ptr/mut_ptr.rs
Outdated
| @@ -689,7 +729,11 @@ impl<T: ?Sized> *mut T { | |||
| { | |||
| // SAFETY: the caller must guarantee that `self` meets all the | |||
| // requirements for a reference. | |||
| if self.is_null() { None } else { Some(unsafe { &mut *(self as *mut MaybeUninit<T>) }) } | |||
| if self.is_null() { | |||
There was a problem hiding this comment.
The rustfmt formatting is unnecessary
- Adds harnesses for int, unit, composite and slice types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #ISSUE-NUMBER
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.