Develop

[auzaheta]

Description

The CRAN team reported that when the package is checked --as-cran finds

* checking use of SHLIB_OPENMP_*FLAGS in Makefiles ... NOTE
  src/Makevars: SHLIB_OPENMP_CXXFLAGS is included in PKG_CXXFLAGS but not in PKG
_LIBS
  src/Makevars: SHLIB_OPENMP_CFLAGS is included in PKG_LIBS but linking is by C+
+

Use of these macros is discussed in sect 1.2.1.1 of ‘Writing R
Extensions’. The macros for different languages may differ so the
matching macro must be used in PKG_CXXFLAGS (etc) and match that used
in PKG_LIBS (except for Fortran: see the manual).

(not seen in any of the regular checks).

In src/Makevars.in you should change

PKG_LIBS= @OPENMP_CFLAG@ $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)

to

PKG_LIBS= @OPENMP_FLAG@ $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)

Checklist:

• I have added tests that prove my fix is effective or that my feature works
• The package builds on my OS without issues (please add workstation details)
• My changes generate no new warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (.R, NEWS.md)
• I have bumped the version by the appropriate increment in the DESCRIPTION file (major, minor, patch)

[jhollway]

Super, thanks @auzaheta!