Three minor fixes #139
Merged
Three minor fixes #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let user configure a zone name. Only allocate a zone if actually needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was building spnego module on FreeBSD 13 with nginx 1.23.4 and ran into a couple of problems:
Additionally, I have my own tests which fail if there is an unexpected shared memory zone in the configuration (I'm using lua module which has to create some specific zones). So I moved shared memory zone creation to a later stage when the module can be sure that it is needed. I also added an option to configure the zone name if needed.
Changes seem to solve my problems and don't break anything for other platform/libraries. I tested it works on debian/ubuntu(MIT based) and bsd system (heimdal)
I guess proper heimdal patch should be more involved but this one works for me. So good enough, I guess.
Let me know if I should split my PR into three separate.
Regards,
oxpa