Skip to content

Add generic F413C/F423C pinout variant #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

MCUdude
Copy link
Contributor

@MCUdude MCUdude commented Feb 10, 2020

This pinout variant adds to the list of similarly formatted generic F4xxC pinout variants.

This pinout variant adds to the list of similarly formatted generic F4xxC pinout variants
@fpistm fpistm self-requested a review February 10, 2020 12:54
@fpistm fpistm added the new variant Add support of new bard label Feb 10, 2020
@fpistm fpistm added this to the 1.9.0 milestone Feb 10, 2020
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @MCUdude

@MCUdude
Copy link
Contributor Author

MCUdude commented Feb 10, 2020

I'd probably make a pinout for a 100-pin variant as well. I do have an F407 Disco board, so I might as well make a generic F407/417Vx pinout.

The reason why I'd like to make a generic 100-pin F4 variant is that if others want to make variants for other 100-pin F4's they can just follow the rules I've made 🙂

@fpistm
Copy link
Member

fpistm commented Feb 11, 2020

I'd probably make a pinout for a 100-pin variant as well. I do have an F407 Disco board, so I might as well make a generic F407/417Vx pinout.

I guess it should be fine to extend genpinmap script to generate the skeleton (i.e. prefilled variant.*)
It is possible as it is aware of all available pins.

@fpistm fpistm merged commit 0c25db2 into stm32duino:master Feb 11, 2020
@uzi18
Copy link

uzi18 commented Feb 11, 2020

so i'm waiting for F407ZET6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants