overall option code rework #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
derp, merge issue, lemme see.. |
User could get a wrong "stlink_fread()" error in case of bad stlink_read_option_foo..
use g0 code, same logic with different base address. also cleanup some duplicate lock/unlock code.
unify option bytes read/write, interface, use chipid db to store size and base to provide some write sanity check and generic option read code.
current opt parse code can make bad cmdline parameter attempt to flash bad flash option. ie: calling st-flash write --area=option a_file.bin will make parser attempt to translate "a_file.bon" to an uint32 and will return 0..,
avoid some potential issues later.
grevaillot
force-pushed
the
to_merge/option
branch
from
1f53d38
to
3aaec27
Compare
|
pushed force, better, not sure what happened |
|
Great! Give me some time to review. I don't mind though if you add further commits in the meanwhile, if you feel like it. To me PRs don't necessarily need to stay below a certain size as long as they focus on one topic. Keep up the good work! 👍 |
|
i've got a bigger patch to come with more refactoring, but this will need some testing and a bit of time .. that one can be merged i think |
Nightwalker-87
approved these changes
Apr 19, 2020
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
Continuing my work on g4 fixes, i added support for g0/g4 chips option read/write, and spend a bit of time on option code cleanup/rework.
basically, I moved some device specific code out of st-flash util, aligned api regarding option/read write device specific code and added device specific parameter to chipid database, allowing some sanity checks before writing and some generic option read code. all devices are now using the same code to flash option, not depending on st-flash parameters.
note that current option write code mostly only support writing the first 32bits of option bytes, nor reading more, so this need some more reviews / rework to be safe, but i think this is not less safe than previously - currently option size is hardcoded to 32bits for concerned/not tested chips.
I can maybe split pr, this went a bit wild while attempting to add my stuff..