fixes texane/stlink#780

[ceremcem]

No description provided.

[xor-gate]

As my comment before, I think in the upper layers we should catch the error -1 and exit (or retry with exponential backoff using rescan). I think a different implementation is necessary for that. Do you feel to fix this or leave it as is ?

[ceremcem]

Sorry for being unresponsive for that long time. I had had many distractions and I still have. Current workaround works for me but it is apparently a dirty hack and needs to be improved as you suggested. I'm willing to implement the proper solution ASAP.

[Nightwalker-87]

@ceremcem: Thx for your contribution. Could you target the develop branch for that PR? Also I see that this bring up an old discussion on the backend. Can we be sure in the meanwhile that this does not break anything currently working?

[ceremcem]

Could you target the develop branch for that PR?

Sure thing.

Can we be sure in the meanwhile that this does not break anything currently working?

I'll take extreme caution on this.

[bmarvo]

I agree that we should not be calling exit() here. This will result in undesired behavior for projects that embed libstlink. We do need to get a better understanding of how returning -1 here affects the higher layers.

[Nightwalker-87]

@ceremcem: This PR will be closed in 3 days, should there be no further feedback.

[ceremcem]

Hi! I'm on this one at last.

Any fix would need a test case in order to prevent any breakage in the higher layers. What would you recommend? Should I write my-st-util or is there any application I can use as a test case?

[Nightwalker-87]

Can you just use st-util from the develop branch?

[Nightwalker-87]

Closed by PR #913.