Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded and revised list of chips #1145

Merged
merged 2 commits into from
May 31, 2021

Conversation

Ant-ON
Copy link
Collaborator

@Ant-ON Ant-ON commented May 24, 2021

The list of chips is expanded with missing ones in accordance with the ST documentation
All the names of the chips are brought to the same style
Fixed incorrect size of SRAM of the G0 chips (not critical, but it would be better if it would correspond to the documentation)

Nightwalker-87 and others added 2 commits May 24, 2021 12:13
- Updated CHANGELOG.md
- Updated GitHub security policy
- [doc] Updated steps for release procedure
- [doc] Updated list of supported OS
- Removed old clang_analyze script
- Minor fix in travis build script
@Nightwalker-87 Nightwalker-87 changed the base branch from develop to testing May 26, 2021 20:33
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 26, 2021

@Ant-ON I switched this to the testing branch, because I had updated the names and also unified the chip-id defines as part of the chip-config separation from the source code (#1129). So one has to resolve the differences: Use of the changed defines + additional changes to the descriptions from your side. Both is useful, but conflicts need to be resolved.

@Nightwalker-87 Nightwalker-87 added this to the v1.7.1 milestone May 26, 2021
@Nightwalker-87
Copy link
Member

As I have noticed, some defines need to be updated as well. As currently proposed (see testing branch) I'd prefer to use a small "x" for placeholders in MCU names/types to distinguish from the capital "X" used by ST Microelectronics in some MCU part names.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented May 27, 2021

@Nightwalker-87 In the test branch is missing eafb4d1 and f02618c commits. Conflicts due to their absence.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented May 27, 2021

@Nightwalker-87 In most codding standards the enum names naming according to the rule: "Labels All Upper Case with '_' Word Separators". Using the "x" char is not entirely correct.

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 27, 2021

One may also use another symbol as a placeholder like $ etc. as well as long as it is part of the ASCII character set.

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 30, 2021

@Ant-ON Can we proceed here to allow for the subsequent conclusion of @rewolff's contributon on the testing branch?

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented May 31, 2021

@Nightwalker-87 Everything is ready here and nothing needs to be changed. In the test branch is lack previous corrections by other authors (it's produced conflict). "X" is not used in the names of MСU. "X" is used in enum names and this follows their naming standards.

@Nightwalker-87
Copy link
Member

@Ant-ON No, there were some renamed defines that have already been replaced in other source files. These changes are in testing already. Thus this has to be reviewed with care. There are relevant / useful changes from both versions.

@Nightwalker-87 Nightwalker-87 merged commit 98e0a75 into stlink-org:testing May 31, 2021
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 31, 2021

Merged manually preserving the defines from the current branch.
Some more precise descriptions should now be used to allign related defines.
These changes will be applied on the testing branch soon.

@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 31, 2021
@Nightwalker-87 Nightwalker-87 linked an issue Jul 28, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.