JSONTokener recognizes -0 as a string not as a number, based on usage from json-schema

[coderextreme]

See: everit-org/json-schema#25

[johnjaylward]

I fixed this in #157 and #158 but it was not accepted.

[johnjaylward]

https://github.com/johnjaylward/JSON-java/tree/FixBigIntRead has the latest changes outside of PR #158

[coderextreme]

This is breaking schema validation because strings (-0) aren't numbers. We might be able to change the JSON, but it seems odd that this is not acceptable to JSON-java. -0 is well-defined in the spec and does exceed any limits.

[johnjaylward]

How would you propose to see -0? as a 0 integer, or as a -0 double/float?

[stleary]

Does anyone disagree with the problem statement:
"JSON-Java is not following the spec when parsing the value, '-0'. It should be parsed as a number instead of a string."

[Merlinio]

@coderextreme I'm not sure if I understand what's the problem. You are saying that -0 is breaking schema. Which schema do you mean? According to information at JSON.org and there mentioned ECMA-404, such token should be considered as a number. So, the original appeal that tokenizer in JSON-java is processing such token as a string incorrectly is valid. Although the existence of something like negative zero is really strange.

[coderextreme]

Good question, looking at the schema, I either want an integer or a number. I would say integer (since integers are numbers), then parse -0.0 as a float/double.

John

On Jan 27, 2016, at 10:06 AM, johnjaylward notifications@github.com wrote:

How would you propose to see -0? as a 0 integer, or as a -0 double/float?

—
Reply to this email directly or view it on GitHub #187 (comment).

[johnjaylward]

@Ronon-Dex when performing math with doubles and floats, a -0.0 is a possible value. I don't see it's existence as strange

@stleary I believe it should be parsed as a number. In both specs mentioned in the readme, it should be a number and not a string. I'm working on a PR right now with test cases included

[johnjaylward]

Also, I don't believe this is a problem in the JSONTokener. It treats everything as a string value until it's passed up to the JSONObject.stringToValue method. The PR I'm creating will only have changes in that method.

[stleary]

@johnjaylward Thanks, I will work on the unit test side.

[Merlinio]

@johnjaylward Yes, I agree with you. I didn't speak about the floating points. I'm thinking about negative integer zero but that's not the subject. Nevermind ;-)

@stleary I agree with John. This should be parsed as a number.

[coderextreme]

@Ronon-Dex it's breaking the org.everit json-schema package, everit-org/json-schema#25 It's the only Java JSON schema validator published on json-schema.org which hasn't been abandoned.

[coderextreme]

Sorry I can't get a better URL for you to look at. It's local to github. And I don't really know markdown.

Here's the non-issue link: https://github.com/everit-org/json-schema