Improved install support, including support for BUILD_INTERFACE #16
+78
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing minor version inconsistency in actions/checkout.
Expanded README with detailed instructions for testing installations and re-exporting dependencies using BUILD_INTERFACE, clarifying CMake best practices. Updated cpp-library-install.cmake to extract dependencies from BUILD_INTERFACE generator expressions for correct find_dependency() generation. Added an 'install' preset to CMakePresets.json for streamlined installation and testing of installed packages.
Updates the dependency export logic to only process BUILD_INTERFACE targets that are namespaced (external dependencies). Non-namespaced BUILD_INTERFACE targets, which are local build targets, are now skipped to avoid incorrect dependency tracking.
sean-parent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds an install preset and extracts BUILD_INTERFACE dependencies for correct find_dependency generation; updates README and bumps actions/checkout to v6.
BUILD_INTERFACEin_cpp_library_generate_dependenciesto track namespaced deps forfind_dependency(); skip other generator expressions.installconfigure/build presets intemplates/CMakePresets.json(Release,CPM_USE_LOCAL_PACKAGES=ON).installpreset; document re-exporting deps viaBUILD_INTERFACEand why; add best-practice note forCPM_SOURCE_CACHE.actions/checkouttov6intemplates/.github/workflows/ci.yml.in.Written by Cursor Bugbot for commit 2e9b271. This will update automatically on new commits. Configure here.