Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci updates #70
ci updates #70
Changes from 24 commits
b484279
1dd1caa
b047532
c7ed2bf
a028cf3
5298ec0
345838b
8fe2c54
755fa1c
17ad22e
5bb6207
14764b0
573e646
adddbe8
68b3264
5360f9a
cff3c0f
43ae103
a156f11
b579d71
bcd3df1
d935b72
1529b01
49beec6
67ec206
cbbfbdd
1d7ad96
f32cedc
575a6a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My inclination would be to have the
ARG
declarations directly under theFROM
statement. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my testing (didn't read docs to confirm), the
ARG
only applies to theRUN
command immediately following. At least the build was failing when I had it as you suggestedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, that wasn't my understanding, but I don't think it is important enough to hold this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adthrasher I haven't pushed a
cellranger:1.1.0
image. How do we want to handle which version of CellRanger to use?1.0.0
uses cellranger7.0.1
. The link we provide in the new Dockerfile only supplies whatever the latest version is. Manually push with7.0.1
because that's what's been tested? Bump to latest?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Andrew Thrasher. I just moved these to the top and tried the docker build, and it worked fine for me.
Also, I don't think we want to be actually packaging cell ranger and distributing it via GitHub packages. @adthrasher have we looked at the licensing at all around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should probably get their license reviewed. The package is set to internal for now. Even that may not technically be allowable based on the terms of the 10x license.