Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max_iterations_per_try dynamic #88

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Make max_iterations_per_try dynamic #88

merged 2 commits into from
Feb 21, 2023

Conversation

a-frantz
Copy link
Member

No description provided.

@a-frantz a-frantz self-assigned this Feb 15, 2023
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why the Python version restriction?

@a-frantz
Copy link
Member Author

First I tried installing with Python3.11 installed and got errors from numpy. Rolled back to 3.10 and installation worked, but attempting a poetry update failed (again due to numpy). Another roll back to Python3.9 and both installation and poetry update went smoothly. Didn't investigate the versioning beyond that, but our packages were clearly incompatible with Python3.11 and 3.10

@a-frantz a-frantz merged commit b6d6269 into master Feb 21, 2023
@a-frantz a-frantz deleted the max-iterations branch February 21, 2023 15:49
a-frantz added a commit that referenced this pull request Feb 21, 2023
* master:
  Make `max_iterations_per_try` dynamic (#88)
a-frantz added a commit that referenced this pull request Mar 3, 2023
* master: (22 commits)
  ci: change to standard naming
  ci: adds repo name to workflows for observability
  chore: bumping version to v2.3.1
  fix: set default `n-genes` to 1000 for improved accuracy
  chore: cleanup CHANGELOG from when I manually added to it
  chore: bumping version to v2.3.0
  chore: revert manual version bump (#93)
  feat: make retries cumulative instead of a reset (#91)
  chore: bumping to version 2.2.1 (#92)
  Make `max_iterations_per_try` dynamic (#88)
  build(deps-dev): bump mypy from 0.910 to 0.920 (#33)
  build(deps-dev): bump twine from 3.7.0 to 3.7.1 (#32)
  build(deps-dev): bump black from 21.11b1 to 21.12b0 (#31)
  ci: updates poetry version in cd pipeline
  build(deps): mass updates to dependencies (#30)
  build(deps): bump bleach from 3.2.1 to 3.3.0 (#27)
  build(deps): bump jinja2 from 2.11.2 to 2.11.3 (#28)
  build(deps): bump sortedcontainers from 2.3.0 to 2.4.0 (#20)
  chore: adds CODEOWNERS file
  ci: changes dependabot updates to weekly
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants