Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse workspace hints sections such that expressions are not supported. #176

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

peterhuene
Copy link
Collaborator

This commit fixes the parsing of workflow hints sections such that the values in the hints sections are always literals (no expressions supported).

To fix this, we need to parse the workflow hints section much like a metadata section where expressions aren't supported.

It required splitting out the previous HintsSection AST representation into two types: TaskHintsSection and WorkflowHintsSection, where the items in the former support expressions for values and the latter does not.

Fixes #169.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

…upported.

This commit fixes the parsing of workflow `hints` sections such that the values
in the `hints` sections are always literals (no expressions supported).

To fix this, we need to parse the `workflow` hints section much like a metadata
section where expressions aren't supported.

It required splitting out the previous `HintsSection` AST representation into
two types: `TaskHintsSection` and `WorkflowHintsSection`, where the items in
the former support expressions for values and the latter does not.

Fixes stjude-rust-labs#169.
wdl-ast/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Thrasher <adthrasher@gmail.com>
@peterhuene peterhuene merged commit c1adb91 into stjude-rust-labs:main Sep 18, 2024
8 checks passed
@peterhuene peterhuene deleted the fix-hint-parsing branch September 18, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing of workflow hints section is incorrect
3 participants