fix: parse workspace hints
sections such that expressions are not supported.
#176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the parsing of workflow
hints
sections such that the values in thehints
sections are always literals (no expressions supported).To fix this, we need to parse the
workflow
hints section much like a metadata section where expressions aren't supported.It required splitting out the previous
HintsSection
AST representation into two types:TaskHintsSection
andWorkflowHintsSection
, where the items in the former support expressions for values and the latter does not.Fixes #169.
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).