fix: add back x-cache-digest header.
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous PR removed the `x-cache-digest` header in all responses. It _should_ have limited the removal to just the times when the cached body isn't being served from the cache. The other instances where we are serving the body from the cache can set the header. Additionally, this updates the `http-cache-semantics` dependency to go back to the upstream crate that doesn't support 206 responses. Given the complexity and narrow scope of supporting very specific ranged requests, it wasn't worth the trouble of implementing it.
peterhuene
requested review from
a-frantz,
acfoltzer,
adthrasher and
claymcleod
claymcleod
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR removed the
x-cache-digestheader in all responses.It should have limited the removal to just the times when the cached body isn't being served from the cache. The other instances where we are serving the body from the cache can set the header.
Additionally, this updates the
http-cache-semanticsdependency to go back to the upstream crate that doesn't support 206 responses.Given the complexity and narrow scope of supporting very specific ranged requests, it wasn't worth the trouble of implementing it.