-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Redis.Cluster
constructor support
#1066
Conversation
Code Climate has analyzed commit 80db0e7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 98.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great starting point! When I started this library I knew little about redis or ioredis, and you could call this whole library a "poor man's ioredis mock" 😂
After applying the review suggestions run these commands, commit and push: npm run lint -- --fix && npx prettier --write .
😄
Co-authored-by: Cody Olsen <stipsan@gmail.com>
Co-authored-by: Cody Olsen <stipsan@gmail.com>
It seems that pre-commit or pre-push hooks could help enforce the linting and formating of PRs. http://npmjs.com/package/husky |
@onichandame yup it's set up but it appears to have stopped working after v5 or something 🤔 Haven't had time to look into what's up... |
🎉 This PR is included in version 5.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Problem
I'm using the following practice:
But this lib does not seem to support cluster creation yet.
Solution
The
Redis.Cluster
constructor is all I need, hence I didn't dig deeply into the internal mechanisms of the redis cluster. I know this is far from complete, so feel free to give advice or simply reject for good :DRelated to #359