Remove unnecessary edge list scan during insert. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running performance regressions now, but this ought to help a lot when adding edges to a high-degree vertex. Please review and make sure I'm not introducing a subtle race condition here, especially in the presence of concurrent deletions. |
ehein6
force-pushed
the
remove-edge-list-scan
branch
from
260d020 to
73a6ab8
Compare
Update year in LICENSE. Update README. Remove SOURCEME script.
Despite BUILD_SHARED_LIBS being displayed as an option, CMake would always build shared libraries because each add_library command also specified the SHARED argument. By removing this argument, each library added will look at the global BUILD_SHARED_LIBS variable when deciding to generate a static or shared library. As a result, stinger can now be built with either static or shared libraries.
Several files in stinger_alg were including headers from stinger_net and stinger_utils, despite not using any functions from these libraries. stinger_alg now depends only on stinger_core and libcompat, as it should.
streaming_connected_components uses a struct defined in a stinger_net header. This dependency wasn't getting picked up by CMake because of the order in which subdirectories in lib were getting added. There is still no link dependency between stinger_alg and stinger_net.
When a thread reaches the end of the edge list without finding a spot for the edge it is trying to insert/update, it tries to atomically swap in a new edge block on the end of the list. If this fails, the existing code would return to the beginning of the list and re-scan the entire thing before trying to swap in a new block. With this patch, the thread just keeps searching from its current position.
ehein6
force-pushed
the
remove-edge-list-scan
branch
from
73a6ab8 to
8b6434f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a thread reaches the end of the edge list without finding a
spot for the edge it is trying to insert/update, it tries to atomically
swap in a new edge block on the end of the list. If this fails, the
existing code would return to the beginning of the list and re-scan
the entire thing before trying to swap in a new block. With this patch,
the thread just keeps searching from its current position.
This change is