Skip to content

Consolidate morph method #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianrubisch merged 2 commits into from
Jul 25, 2022
Merged

Consolidate morph method #597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
122072d
chore: Refactor / consolidate morph method
julianrubisch Jul 21, 2022
b753172
chore: Patch broadcast_(error|forbid|halt)
julianrubisch Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions lib/stimulus_reflex/reflex.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class VersionMismatchError < StandardError; end

delegate :connection, :stream_name, to: :channel
delegate :controller_class, :flash, :session, to: :request
delegate :broadcast, :broadcast_halt, :broadcast_forbid, :broadcast_error, to: :broadcaster
delegate :reflex_id, :tab_id, :reflex_controller, :xpath_controller, :xpath_element, :permanent_attribute_name, :version, :suppress_logging, to: :client_attributes

def initialize(channel, url: nil, element: nil, selectors: [], method_name: nil, params: {}, client_attributes: {})
Expand All @@ -31,7 +30,6 @@ def initialize(channel, url: nil, element: nil, selectors: [], method_name: nil,
@method_name = method_name
@params = params
@client_attributes = ClientAttributes.new(client_attributes)
@broadcaster = StimulusReflex::PageBroadcaster.new(self)
@logger = suppress_logging ? nil : StimulusReflex::Logger.new(self)
@payload = {}
@headers = {}
Expand Down Expand Up @@ -80,10 +78,35 @@ def request
end
end

def broadcast(*args)
morph :page if broadcaster.nil?

broadcaster.broadcast(*args)
end

def broadcast_halt(data:)
morph :page if broadcaster.nil?

broadcaster.broadcast_halt(data: data)
end

def broadcast_forbid(data:)
morph :page if broadcaster.nil?

broadcaster.broadcast_forbid(data: data)
end

def broadcast_error(data:, body:)
morph :page if broadcaster.nil?

broadcaster.broadcast_error(data: data, body: body)
end

def morph(selectors, html = nil)
case selectors
when :page
raise StandardError.new("Cannot call :page morph after :#{broadcaster.to_sym} morph") unless broadcaster.page?
raise StandardError.new("Cannot call :page morph after :#{broadcaster.to_sym} morph") if broadcaster&.selector? || broadcaster&.nothing?
@broadcaster = StimulusReflex::PageBroadcaster.new(self)
when :nothing
raise StandardError.new("Cannot call :nothing morph after :selector morph") if broadcaster.selector?
@broadcaster = StimulusReflex::NothingBroadcaster.new(self) unless broadcaster.nothing?
Expand Down