Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to execute CableReady operations on StimulusReflex::Element #489

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Allow to execute CableReady operations on StimulusReflex::Element #489

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
297d3ac
no more passing schema into functions
leastbad Mar 25, 2021
3724262
extractElementDataset v2
leastbad Mar 25, 2021
2bd9f0a
default case falls through to css instead of xpath
leastbad Mar 25, 2021
0c100e9
Allow to execute CableReady operations on `StimulusReflex::Element`
marcoroth Apr 14, 2021
74aa075
Introduce `Reflex#controller_element` in order to operate on it
marcoroth Apr 14, 2021
1879b65
standardize
marcoroth Apr 14, 2021
ce97d59
Merge branch 'main' into cable-ready-on-elements
marcoroth Feb 20, 2023
3e6caf9
Resolve merge artefacts
marcoroth Feb 20, 2023
ac39a6e
just set `cable_ready` on `element` if it's present
marcoroth Feb 20, 2023
05c6da5
`cable_ready` accessor and writer on `element`
marcoroth Feb 20, 2023
bb5d81a
Add `include_private = false` for `#respond_to_missing?`
marcoroth Feb 20, 2023
90fa13a
Add tests
marcoroth Feb 21, 2023
1bf7a8c
standardize
marcoroth Feb 21, 2023
ad5e287
Make `controller_element` available in reflex
marcoroth Feb 21, 2023
1f38f9e
standardize
marcoroth Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
standardize
  • Loading branch information
@marcoroth
marcoroth committed Feb 21, 2023
commit 1bf7a8c82f9a0bbec688e20b8972c46eb2750105
8 changes: 4 additions & 4 deletions test/reflex_element_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def build_payload(operations = [])

test "broadcasts updates using element.broadcast" do
expected = build_payload(
{"selector"=>"#element-selector", "xpath"=>false, "html"=>"<p>Some HTML</p>", "reflexId"=>"666", "operation"=>"innerHtml"}
{"selector" => "#element-selector", "xpath" => false, "html" => "<p>Some HTML</p>", "reflexId" => "666", "operation" => "innerHtml"}
)

assert_broadcast_on(@reflex.stream_name, expected) do
Expand All @@ -40,7 +40,7 @@ def build_payload(operations = [])

test "selector can be overwritten" do
expected = build_payload(
{"selector"=>"#overwritten", "xpath"=>false, "html"=>"<p>Some HTML</p>", "reflexId"=>"666", "operation"=>"innerHtml"}
{"selector" => "#overwritten", "xpath" => false, "html" => "<p>Some HTML</p>", "reflexId" => "666", "operation" => "innerHtml"}
)

assert_broadcast_on(@reflex.stream_name, expected) do
Expand All @@ -50,8 +50,8 @@ def build_payload(operations = [])

test "broadcasts using element.broadcast chained" do
expected = build_payload [
{"selector"=>"#element-selector", "xpath"=>false, "html"=>"<p>Some HTML</p>", "reflexId"=>"666", "operation"=>"innerHtml"},
{"name"=>"abc", "detail"=>{"some"=>"key"}, "reflexId"=>"666", "selector"=>"#element-selector", "operation"=>"dispatchEvent"}
{"selector" => "#element-selector", "xpath" => false, "html" => "<p>Some HTML</p>", "reflexId" => "666", "operation" => "innerHtml"},
{"name" => "abc", "detail" => {"some" => "key"}, "reflexId" => "666", "selector" => "#element-selector", "operation" => "dispatchEvent"}
]

assert_broadcast_on(@reflex.stream_name, expected) do
Expand Down