Merge pull request #66 from nodejs/master

test: workaround for V8 8.1 inspector pause issue
sthagen · Mar 16, 2020 · 7ab3cf0 · 7ab3cf0
2 parents ef28822 + 2e3dc12
commit 7ab3cf0
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/test/fixtures/inspector-global-function.js b/test/fixtures/inspector-global-function.js
@@ -10,4 +10,8 @@ global.sum = function() {
   console.log(invocations++, c);
 };
 
+// NOTE(mmarchini): Calls console.log two times to ensure we loaded every
+// internal module before pausing. See
+// https://bugs.chromium.org/p/v8/issues/detail?id=10287.
+console.log('Loading');
 console.log('Ready!');
diff --git a/test/parallel/test-inspector-multisession-ws.js b/test/parallel/test-inspector-multisession-ws.js
@@ -20,6 +20,7 @@ session.on('Debugger.paused', () => {
 session.connect();
 session.post('Debugger.enable');
 console.log('Ready');
+console.log('Ready');
 `;
 
 async function setupSession(node) {
@@ -46,6 +47,10 @@ async function testSuspend(sessionA, sessionB) {
   await sessionA.waitForNotification('Debugger.paused', 'Initial pause');
   sessionA.send({ 'method': 'Debugger.resume' });
 
+  await sessionA.waitForNotification('Runtime.consoleAPICalled',
+                                     'Console output');
+  // NOTE(mmarchini): Remove second console.log when
+  // https://bugs.chromium.org/p/v8/issues/detail?id=10287 is fixed.
   await sessionA.waitForNotification('Runtime.consoleAPICalled',
                                      'Console output');
   sessionA.send({ 'method': 'Debugger.pause' });

diff --git a/test/sequential/test-inspector-break-when-eval.js b/test/sequential/test-inspector-break-when-eval.js
@@ -18,7 +18,15 @@ async function setupDebugger(session) {
     { 'method': 'Runtime.runIfWaitingForDebugger' },
   ];
   session.send(commands);
-  await session.waitForNotification('Runtime.consoleAPICalled');
+
+  await session.waitForNotification('Debugger.paused', 'Initial pause');
+
+  // NOTE(mmarchini): We wait for the second console.log to ensure we loaded
+  // every internal module before pausing. See
+  // https://bugs.chromium.org/p/v8/issues/detail?id=10287.
+  const waitForReady = session.waitForConsoleOutput('log', 'Ready!');
+  session.send({ 'method': 'Debugger.resume' });
+  await waitForReady;
 }
 
 async function breakOnLine(session) {
@@ -56,7 +64,9 @@ async function stepOverConsoleStatement(session) {
 }
 
 async function runTests() {
-  const child = new NodeInstance(['--inspect=0'], undefined, script);
+  // NOTE(mmarchini): Use --inspect-brk to improve avoid undeterministic
+  // behavior.
+  const child = new NodeInstance(['--inspect-brk=0'], undefined, script);
   const session = await child.connectInspectorSession();
   await setupDebugger(session);
   await breakOnLine(session);