-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type guard stmt bug and update tests. #438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 91.96% 92.02% +0.05%
==========================================
Files 85 85
Lines 13644 13643 -1
==========================================
+ Hits 12548 12555 +7
+ Misses 1096 1088 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Just a couple of minor things to tidy up and then this can go on.
No need to update docs as this is a bug fix.
I'll take this on - there's not much to do. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 92.07% 92.13% +0.05%
==========================================
Files 85 85
Lines 13825 13824 -1
==========================================
+ Hits 12730 12737 +7
+ Misses 1095 1087 -8 ☔ View full report in Codecov by Sentry. |
Just finishes off a small bugfix. Ready for review from either @hiker or @sergisiso. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this PR @arporter. The associated issue has been fixed and the type guard tests have also improved, this is approved for merging.
There was a bug in the type_guard_stmt match method. Updated the code and associated tests. The restructuring of the code actually removes the offending line of code.