Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Amended environment variables GRAFANA with GF #149

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Vinci-C
Copy link
Contributor

@Vinci-C Vinci-C commented Jun 21, 2024

In compose.yaml
- GF_GRAFANA_DOMAIN_NAME=$GRAFANA_DOMAIN_NAME
- GRAFANA_ROOT_URL=$GRAFANA_ROOT_URL
changed to
- GF_SERVER_DOMAIN_NAME=$GRAFANA_DOMAIN_NAME
- GF_SERVER_ROOT_URL=$GRAFANA_ROOT_URL

@khalford
Copy link
Member

What does this fix?

@Vinci-C
Copy link
Contributor Author

Vinci-C commented Jun 21, 2024

Allows the grafana container to recognise the variables as the syntax was not consistent before

Copy link
Member

@khalford khalford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidFair DavidFair merged commit 73e63db into stfc:master Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants