Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache 2.0 License #124

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Add Apache 2.0 License #124

merged 3 commits into from
Dec 6, 2023

Conversation

DavidFair
Copy link
Collaborator

Adds the Apache 2.0 license to allow code re-use. We've chosen this license for this repo because:

  • We don't mind people adapting and either partial or complete bits of code for their own projects.

  • Any modifications is likely to be bespoke to their env. and needs. Whilst it would be nice to share around, a strong copy-left requirement is likely to prevent people re-using bits, which we wouldn't likely benefit from anyway.

  • It still allows attribution, as we're just as happy to collaborate where we can too.


Resolves: #123

Adds the Apache 2.0 license to allow code re-use. We've chosen this
license for this repo because:

- We don't mind people adapting and either partial or complete bits of
  code for their own projects.

- Any modifications is likely to be bespoke to their env. and needs.
  Whilst it would be nice to share around, a strong copy-left
  requirement is likely to prevent people re-using bits, which we
  wouldn't likely benefit from anyway.

- It still allows attribution, as we're just as happy to collaborate
  where we can too.
@DavidFair DavidFair force-pushed the Add_license branch 2 times, most recently from b260eee to 34af811 Compare December 1, 2023 16:20
Applies SPDX identifier across the repo automatically to indicate the
Apache-2.0 license and owner
Copy link
Contributor

@meoflynn meoflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Openstack-accounting directory contains some SQL scripts, I think we need to add the license to these ones as well?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2820a07) 97.92% compared to head (d5ce2e5) 96.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   97.92%   96.81%   -1.11%     
==========================================
  Files          50       16      -34     
  Lines        1828     1069     -759     
==========================================
- Hits         1790     1035     -755     
+ Misses         38       34       -4     
Flag Coverage Δ
rabbit_consumer 96.81% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidFair
Copy link
Collaborator Author

Build failure is unrelated, I'm happy with your changes @meoflynn - could I get you to re-review my aspects?

@jacob-ward jacob-ward merged commit 1e56165 into master Dec 6, 2023
16 of 20 checks passed
@khalford khalford deleted the Add_license branch September 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENSE file missing
4 participants