Written tests for get_id_from_key method. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for the above method and changed some enums stuff in the code.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 90.66% 93.72% +3.05%
==========================================
Files 12 12
Lines 225 239 +14
==========================================
+ Hits 204 224 +20
+ Misses 21 15 -6
☔ View full report in Codecov by Sentry. |
anish-mudaraddi
approved these changes
Oct 30, 2023
Koldstream
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the above method and changed some enums stuff in the code. Removed attributes from netbox_get_id class as these enums will not be changed therefore do not need to be assigned.