Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing config options, fix default values and layout #20

Merged
merged 2 commits into from
Nov 4, 2013

Conversation

fqxp
Copy link
Contributor

@fqxp fqxp commented Nov 1, 2013

Hi,

  • I added two missing options (:crawl_finished_queue and :use_encoding_safe_process_job) to the list of Cobweb options because they're missing and I think they're quite important.
  • I also clarified the default values for the two queue options: 1. they're strings, not class names and 2. they're different for sidekiq users.
  • also added @s around the :valid_mime_types default value so it becomes properly visible on github (*/* on its own only emphasizes the slash). Might be reasonable to do this for all the symbols, but I didn't want to send a layout-only pull request.
    Frank

stewartmckee added a commit that referenced this pull request Nov 4, 2013
Add missing config options, fix default values and layout
@stewartmckee stewartmckee merged commit f9bbce2 into stewartmckee:master Nov 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants