Touch problems fix #1214
Open
Touch problems fix #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2018 09:51
This caused many Problems with touch events in IOS and Chrome Browsers, because the whole touch event was consumed by the slider: no touch scrolling in any direction no click events
|
@stevenwanderski – can you please fix this? Slider is broken on so many websites. |
…e bxslider in chrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes touch related problems (#1197 #1113).
The whole touch event was consumed through the use of e.preventDefault(). Because of that, one could only use touch event to interact with the slider but could not use touch to scroll or do anything else.
For me it was unclear why this line was even added, the commit message was not very explanatory.