wrap node-sass error message in Error object

closes #15 - when using Metalsmith cli, errors are expected to an actual error object, not a string
stevenschobert · Jan 30, 2015 · 9a15861 · 9a15861
1 parent d2f4610
commit 9a15861
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -32,15 +32,18 @@
             includePaths: includes,
             imagePath: imagePath,
             outputStyle: outputStyle,
-            success: function(css) {
+            success: function handleSuccess(css) {
               // replace contents
               file.contents = new Buffer(css);
               // rename file extension
               files[path.join(outputDir, path.basename(filename).replace('.scss', '.css'))] = file;
               delete files[filename];
               done();
             },
-            error: function(err) {
+            error: function handleError(err) {
+              if (typeof err === 'string') {
+                err = new Error(err);
+              }
               done(err);
             }
           });

diff --git a/test/test.js b/test/test.js
@@ -105,15 +105,15 @@
         });
       });
 
-      it('should fail when invalid file provided', function(done) {
+      it('should correctly report errors to Metalsmith', function(done) {
         metalsmith(__dirname)
           .source('fixtures/invalid/src')
           .destination('fixtures/invalid/build')
           .use(sass({
             outputStyle: 'expanded'
           }))
           .build(function (err) {
-            assert.notEqual(err, null, "Error should be set.");
+            assert(err.message && /aninvalidrule/.test(err.message));
             assert(!exists(join(__dirname, 'fixtures/invalid/build/invalid.scss')));
             done();
           });