Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindOctave broken #314

Closed
Flamefire opened this issue Jan 30, 2020 · 0 comments
Closed

FindOctave broken #314

Flamefire opened this issue Jan 30, 2020 · 0 comments

Comments

@Flamefire
Copy link

You require the INCLUDE_DIRS in

nlopt/cmake/FindOctave.cmake

Line 186 in 5e2d81c

find_package_handle_standard_args (Octave REQUIRED_VARS OCTAVE_EXECUTABLE OCTAVE_ROOT_DIR OCTAVE_INCLUDE_DIRS OCTAVE_LIBRARIES VERSION_VAR OCTAVE_VERSION_STRING)
but that is always set:

nlopt/cmake/FindOctave.cmake

Line 149 in 5e2d81c

set (OCTAVE_INCLUDE_DIRS ${OCTAVE_INCLUDE_DIR} ${OCTAVE_INCLUDE_DIR}/octave)

Hence the OCTAVE_FOUND can be set even though the headers may not exist leading to bugs, like easybuilders/easybuild-easyconfigs#9801

I suggest to drop the "/octave" adding as it is not required: https://github.com/stevengj/nlopt/blob/master/src/octave/nlopt_optimize-oct.cc#L23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Flamefire