Deterministic callback counters in specs

Author: Steven Allen

spec/controllers/scim_rails/scim_resource_controller_spec.rb

@@ -70,7 +70,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          expect{ get :resource_user }.to change{ counter.count }.from(0).to(1)  
+          expect{ get :resource_user }.to change{ counter.before_called }.from(0).to(1)  
         end
       end
 
@@ -85,8 +85,8 @@
           ScimRails.config.after_scim_response = nil
         end
 
-        it "successfully calls before_scim_response" do
-          expect{ get :resource_user }.to change{ counter.count }.from(0).to(2)  
+        it "successfully calls after_scim_response" do
+          expect{ get :resource_user }.to change{ counter.after_called }.from(0).to(1) 
         end
       end
     end
@@ -154,7 +154,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          expect{ get :resource_group }.to change{ counter.count }.from(0).to(1)
+          expect{ get :resource_group }.to change{ counter.before_called }.from(0).to(1)
         end
       end
 
@@ -170,7 +170,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          expect{ get :resource_group }.to change{ counter.count }.from(0).to(2)
+          expect{ get :resource_group }.to change{ counter.after_called }.from(0).to(1)
         end
       end
     end

spec/controllers/scim_rails/scim_schema_controller_spec.rb

@@ -77,7 +77,7 @@ module ScimRails
           end
 
           it "successfully calls before_scim_response" do
-            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.count }.from(0).to(1)
+            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.before_called }.from(0).to(1)
           end
         end
 
@@ -93,7 +93,7 @@ module ScimRails
           end
 
           it "successfully calls after_scim_response" do
-            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.count }.from(0).to(2)
+            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.after_called }.from(0).to(1)
           end
         end
       end

spec/controllers/scim_rails/scim_service_controller_spec.rb

@@ -70,7 +70,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          expect{ get :configuration }.to change{ counter.count }.from(0).to(1)
+          expect{ get :configuration }.to change{ counter.before_called }.from(0).to(1)
         end
       end
 
@@ -86,7 +86,7 @@
         end
 
         it "successfully calls after_scim_response" do
-          expect{ get :configuration }.to change{ counter.count }.from(0).to(2)
+          expect{ get :configuration }.to change{ counter.after_called }.from(0).to(1)
         end
       end
     end

spec/support/callback_helper.rb

@@ -1,17 +1,18 @@
 module CallbackHelper
   class CallbackCounter
-    attr_reader :count
+    attr_reader :before_called, :after_called
     attr_accessor :before, :after
 
     def initialize
-      @count = 0
+      @before_called = 0
+      @after_called = 0
 
       @before = lambda do
-        @count += 1
+        @before_called += 1
       end
 
       @after = lambda do
-        @count += 2
+        @after_called += 1
       end
     end
   end