tests add to a counter instead of printing to output

Author: myang0

spec/controllers/scim_rails/scim_resource_controller_spec.rb

@@ -2,6 +2,9 @@
 
 RSpec.describe ScimRails::ScimResourceController, type: :controller do
   include AuthHelper
+  include CallbackHelper
+
+  let!(:counter) { CallbackHelper::CallbackCounter.new }
 
   routes { ScimRails::Engine.routes }
 
@@ -58,7 +61,7 @@
       context "when before_scim_response is defined" do
         before do
           ScimRails.config.before_scim_response = lambda do |body|
-            print "#{body}"
+            counter.before.call
           end
         end
 
@@ -67,16 +70,14 @@
         end
 
         it "successfully calls before_scim_response" do
-          get :resource_user
-
-          expect{ get :resource_user }.to output("#{request.params}").to_stdout
+          expect{ get :resource_user }.to change{ counter.count }.from(0).to(1)  
         end
       end
 
       context "when after_scim_response is defined" do
         before do
           ScimRails.config.after_scim_response = lambda do |object, status|
-            print "#{object} #{status}"
+            counter.after.call
           end
         end
 
@@ -85,9 +86,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          get :resource_user
-
-          expect{ get :resource_user }.to output("#{ScimRails.config.resource_user_schema} RETRIEVED").to_stdout
+          expect{ get :resource_user }.to change{ counter.count }.from(0).to(2)  
         end
       end
     end
@@ -146,7 +145,7 @@
       context "when before_scim_response is defined" do
         before do
           ScimRails.config.before_scim_response = lambda do |body|
-            print "#{body}"
+            counter.before.call
           end
         end
 
@@ -155,16 +154,14 @@
         end
 
         it "successfully calls before_scim_response" do
-          get :resource_group
-
-          expect{ get :resource_group }.to output("#{request.params}").to_stdout
+          expect{ get :resource_group }.to change{ counter.count }.from(0).to(1)
         end
       end
 
       context "when after_scim_response is defined" do
         before do
           ScimRails.config.after_scim_response = lambda do |object, status|
-            print "#{object} #{status}"
+            counter.after.call
           end
         end
 
@@ -173,7 +170,7 @@
         end
 
         it "successfully calls before_scim_response" do
-          expect{ get :resource_group }.to output("#{ScimRails.config.resource_group_schema} RETRIEVED").to_stdout
+          expect{ get :resource_group }.to change{ counter.count }.from(0).to(2)
         end
       end
     end

spec/controllers/scim_rails/scim_schema_controller_spec.rb

@@ -3,6 +3,8 @@
 module ScimRails
   RSpec.describe ScimSchemaController, type: :controller do
     include AuthHelper
+    include CallbackHelper
+
     routes { ScimRails::Engine.routes }
 
     describe "get_schema" do
@@ -32,6 +34,8 @@ module ScimRails
 
       context "when authorized" do
         let(:body) { JSON.parse(response.body) }
+
+        let!(:counter) { CallbackHelper::CallbackCounter.new }
 
         before :each do
           http_login(company)
@@ -64,7 +68,7 @@ module ScimRails
         context "when before_scim_response is defined" do
           before do
             ScimRails.config.before_scim_response = lambda do |body|
-              print "#{body}"
+              counter.before.call
             end
           end
 
@@ -73,16 +77,14 @@ module ScimRails
           end
 
           it "successfully calls before_scim_response" do
-            get :get_schema, params: { id: 1 }
-
-            expect{ get :get_schema, params: { id: 1 } }.to output("#{request.params}").to_stdout
+            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.count }.from(0).to(1)
           end
         end
 
         context "when after_scim_response is defined" do
           before do
             ScimRails.config.after_scim_response = lambda do |object, status|
-              print "#{object} #{status}"
+              counter.after.call
             end
           end
 
@@ -91,7 +93,7 @@ module ScimRails
           end
 
           it "successfully calls after_scim_response" do
-            expect{ get :get_schema, params: { id: 1 } }.to output("#{{}} RETRIEVED").to_stdout
+            expect{ get :get_schema, params: { id: 1 } }.to change{ counter.count }.from(0).to(2)
           end
         end
       end

spec/controllers/scim_rails/scim_service_controller_spec.rb

@@ -2,6 +2,7 @@
 
 RSpec.describe ScimRails::ScimServiceController, type: :controller do
   include AuthHelper
+  include CallbackHelper
 
   routes { ScimRails::Engine.routes }
 
@@ -33,6 +34,8 @@
     context "when authorized" do
       let(:body) { JSON.parse(response.body) }
 
+      let!(:counter) { CallbackHelper::CallbackCounter.new }
+
       before :each do
         http_login(company)
       end
@@ -58,7 +61,7 @@
       context "when before_scim_response is defined" do
         before do
           ScimRails.config.before_scim_response = lambda do |body|
-            print "#{body}"
+            counter.before.call
           end
         end
 
@@ -67,16 +70,14 @@
         end
 
         it "successfully calls before_scim_response" do
-          get :configuration
-
-          expect{ get :configuration }.to output("#{request.params}").to_stdout
+          expect{ get :configuration }.to change{ counter.count }.from(0).to(1)
         end
       end
 
       context "when after_scim_response is defined" do
         before do
           ScimRails.config.after_scim_response = lambda do |object, status|
-            print "#{object} #{status}"
+            counter.after.call
           end
         end
 
@@ -85,7 +86,7 @@
         end
 
         it "successfully calls after_scim_response" do
-          expect{ get :configuration }.to output("#{ScimRails.config.config_schema} RETRIEVED").to_stdout
+          expect{ get :configuration }.to change{ counter.count }.from(0).to(2)
         end
       end
     end

spec/support/callback_helper.rb

@@ -0,0 +1,18 @@
+module CallbackHelper
+  class CallbackCounter
+    attr_reader :count
+    attr_accessor :before, :after
+
+    def initialize
+      @count = 0
+
+      @before = lambda do
+        @count += 1
+      end
+
+      @after = lambda do
+        @count += 2
+      end
+    end
+  end
+end