Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_inputs_per_id as argument for ReversibleId#initialize #7

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Add max_inputs_per_id as argument for ReversibleId#initialize #7

merged 5 commits into from
Oct 26, 2023

Conversation

avcwisesa
Copy link
Contributor

@avcwisesa avcwisesa commented Oct 25, 2023 •
edited
Loading

Summary

  • max_inputs_per_id to check length of array provided as input for encode and encode_hex
  • set default max_inputs_per_id to 32

Related issue

#5

Checklist:

  • Updated the documentation accordingly.
  • Added tests to cover changes.
  • All new and existing tests passed.

@stevegeek
Copy link
Owner

Can you please also update the RBS?

@avcwisesa avcwisesa marked this pull request as draft October 26, 2023 14:29
@avcwisesa avcwisesa marked this pull request as ready for review October 26, 2023 14:46
@stevegeek stevegeek merged commit f5e09d6 into stevegeek:main Oct 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegeek stevegeek stevegeek approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avcwisesa @stevegeek