bug: Changing float.max_width and float.max_height is ugly

[budimanjojo]

Did you check the docs and existing issues?

• I have read the docs
• I have searched the existing issues

Neovim version (nvim -v)

0.8.2

Operating system/version

Linux

Describe the bug

Changing float max_height and max_width to >0 broke the float. It's not in the positioned right.

Steps To Reproduce

require("oil").setup({

  float = {
    -- Padding around the floating window
    padding = 2,
    max_width = 40,
    max_height = 40,
    border = "rounded",
    win_options = {
      winblend = 10,
    },
  },
})

Expected Behavior

The float should appear in the middle

Directory structure

No response

Repro

sorry I'm not doing this.

Did you check the bug with a clean config?

• I have confirmed that the bug reproduces with nvim -u repro.lua using the repro.lua file above.

EDIT: I was typing in other place and somehow mixed it up here, updated the problem description :D

[stevearc]

Not sure exactly what your issue was, but I confirmed that the float was being positioned incorrectly. Was that what you were seeing?

[budimanjojo]

Not sure exactly what your issue was, but I confirmed that the float was being positioned incorrectly. Was that what you were seeing?

Yes, it's being positioned at bottom left of the screen and not centered.

[stevearc]

still?

[budimanjojo]

Latest commit fixed it! Thank you! I'll close this now.