Skip to content

feat: add pyupgrade #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

feat: add pyupgrade #737

merged 2 commits into from
Jun 30, 2025

Conversation

filipgodlewski
Copy link
Contributor

@filipgodlewski filipgodlewski commented Jun 25, 2025

feat: add pyupgrade

@github-actions github-actions bot requested a review from stevearc June 25, 2025 18:17
@filipgodlewski
Copy link
Contributor Author

@stevearc it would actually really be nice to add to the meta some sort of notes or implementation remarks so that people get it up front when they read the docs about a particular formatter. What do you think?

@stevearc
Copy link
Owner

Thanks for the PR!

If you want you could add an option for this like we do for rustfmt, then it will show up in this documentation. I'm not too concerned about it, though. My philosophy is if you're using a formatter, you should know what it is and how it works.

@stevearc stevearc merged commit 493b13a into stevearc:master Jun 30, 2025
9 checks passed
@filipgodlewski
Copy link
Contributor Author

Thanks for the PR!

If you want you could add an option for this like we do for rustfmt, then it will show up in this documentation. I'm not too concerned about it, though. My philosophy is if you're using a formatter, you should know what it is and how it works.

Yeah, I thought about it, but then again I don't want to force anyone for a particular version. Pyugrade falls back to --py3 anyways + I think that I saw discussions about using the current environment python version, so yeah, let's maybe leave it as it is 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants