Fix inserting to the end of a range #714
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are formatting with a range, and the formatter tries to insert at the end of the range,
conform.nvim
will fail to insert because it will consider the insert to be happening "outside of the range". But if it's an insert operation that starts immediately after the range, it should be considered still part of the range, since that's basically "appending" to the range, making it longer.This happens a lot with Markdown formatters, for example. Markdown formatters will reorganize reference links alphabetically, meaning they can change the order of links and remove a link from the start of the link section and insert it at the end of the link section, basically "appending" the link at the end.
First, I add a failing test. Then, I add the code that fixes the test.
I figure this PR description is not super intuitive, so I recorded a video showing the bug, it might be easier to grok it.
conform-nvim-bug.mp4