Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.x #509

Merged
merged 22 commits into from
Jan 27, 2020
Merged

V3.x #509

Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added ZED2 STL
  • Loading branch information
Myzhar committed Jan 3, 2020
commit 628ec5e7e056862dd9133aa9b4d70c449561b776
1 change: 1 addition & 0 deletions zed_wrapper/msg/object_stamped.msg
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Standard Header
Header header

# Object label
Expand Down
1 change: 1 addition & 0 deletions zed_wrapper/msg/objects.msg
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
# Array of `object_stamped` topics
object_stamped[] objects
2 changes: 1 addition & 1 deletion zed_wrapper/src/nodelet/include/zed_wrapper_nodelet.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ class ZEDWrapperNodelet : public nodelet::Nodelet {

/* \bried Start tracking
*/
void start_tracking();
void start_pos_tracking();

/* \bried Start spatial mapping
*/
Expand Down
47 changes: 28 additions & 19 deletions zed_wrapper/src/nodelet/src/zed_wrapper_nodelet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -648,14 +648,6 @@ void ZEDWrapperNodelet::readParameters() {
NODELET_INFO_STREAM(" * People detection\t\t-> " << (mObjDetPeople?"ENABLED":"DISABLED"));
mNhNs.getParam("mObjDetEnable/oc_vehicles", mObjDetVehicles);
NODELET_INFO_STREAM(" * Vehicles detection\t\t-> " << (mObjDetVehicles?"ENABLED":"DISABLED"));

mObjDetFilter.clear();
if(mObjDetPeople) {
mObjDetFilter.push_back(sl::OBJECT_CLASS::PERSON);
}
if(mObjDetVehicles) {
mObjDetFilter.push_back(sl::OBJECT_CLASS::VEHICLE);
}
} else {
NODELET_INFO_STREAM(" * Mapping\t\t\t-> DISABLED");
}
Expand Down Expand Up @@ -1116,7 +1108,7 @@ bool ZEDWrapperNodelet::on_set_pose(
mZed.disablePositionalTracking();

// Restart tracking
start_tracking();
start_pos_tracking();

res.done = true;
return true;
Expand All @@ -1143,7 +1135,7 @@ bool ZEDWrapperNodelet::on_reset_tracking(
mZed.disablePositionalTracking();

// Restart tracking
start_tracking();
start_pos_tracking();

res.reset_done = true;
return true;
Expand Down Expand Up @@ -1244,6 +1236,14 @@ bool ZEDWrapperNodelet::start_obj_detect() {
NODELET_INFO_STREAM("Advertised on topic " << mPubObjDetViz.getTopic());
}

mObjDetFilter.clear();
if(mObjDetPeople) {
mObjDetFilter.push_back(sl::OBJECT_CLASS::PERSON);
}
if(mObjDetVehicles) {
mObjDetFilter.push_back(sl::OBJECT_CLASS::VEHICLE);
}

mObjDetRunning = true;
return false;
}
Expand All @@ -1257,7 +1257,7 @@ void ZEDWrapperNodelet::stop_obj_detect() {
}
}

void ZEDWrapperNodelet::start_tracking() {
void ZEDWrapperNodelet::start_pos_tracking() {
NODELET_INFO_STREAM("*** Starting Positional Tracking ***");

NODELET_INFO(" * Waiting for valid static transformations...");
Expand Down Expand Up @@ -2578,7 +2578,7 @@ void ZEDWrapperNodelet::device_poll_thread_func() {

// Start the tracking?
if ((computeTracking) && !mTrackingActivated && (mDepthMode != sl::DEPTH_MODE::NONE)) {
start_tracking();
start_pos_tracking();
}

// Start the mapping?
Expand Down Expand Up @@ -2668,7 +2668,7 @@ void ZEDWrapperNodelet::device_poll_thread_func() {
odomSubnumber > 0;

if (computeTracking) { // Start the tracking
start_tracking();
start_pos_tracking();
}
}

Expand Down Expand Up @@ -2977,7 +2977,7 @@ void ZEDWrapperNodelet::device_poll_thread_func() {

mObjDetMutex.lock();
if (mObjDetRunning) {
std::chrono::steady_clock::time_point start = std::chrono::steady_clock::now();
std::chrono::steady_clock::time_point start = std::chrono::steady_clock::now();
detectObjects(objDetSubnumber > 0, objDetVizSubnumber > 0);
std::chrono::steady_clock::time_point now = std::chrono::steady_clock::now();

Expand Down Expand Up @@ -3603,6 +3603,10 @@ bool ZEDWrapperNodelet::on_start_3d_mapping(zed_wrapper::start_3d_mapping::Reque
mMappingRes = req.resolution;
mFusedPcPubFreq = req.fused_pointcloud_freq;

NODELET_DEBUG_STREAM(" * Mapping resolution\t\t-> " << sl::toString(
static_cast<sl::SpatialMappingParameters::MAPPING_RESOLUTION>(mMappingRes)));
NODELET_DEBUG_STREAM(" * Fused point cloud freq:\t-> " << mFusedPcPubFreq << " Hz");

mMappingEnabled = true;
res.done = true;

Expand Down Expand Up @@ -3645,10 +3649,15 @@ bool ZEDWrapperNodelet::on_start_object_detection(zed_wrapper::start_object_dete

mObjDetRunning = false;

req.confidence;
req.tracking;
req.people;
req.vehicles;
mObjDetConfidence = req.confidence;
mObjDetTracking = req.tracking;
mObjDetPeople = req.people;
mObjDetVehicles = req.vehicles;

NODELET_DEBUG_STREAM(" * Object min. confidence\t-> " << mObjDetConfidence);
NODELET_DEBUG_STREAM(" * Object tracking\t\t-> " << (mObjDetTracking?"ENABLED":"DISABLED"));
NODELET_DEBUG_STREAM(" * People detection\t\t-> " << (mObjDetPeople?"ENABLED":"DISABLED"));
NODELET_DEBUG_STREAM(" * Vehicles detection\t\t-> " << (mObjDetVehicles?"ENABLED":"DISABLED"));

mObjDetEnabled = true;
res.done = true;
Expand Down Expand Up @@ -3791,7 +3800,7 @@ void ZEDWrapperNodelet::detectObjects(bool publishObj, bool publishViz) {

label.text = std::to_string(data.id) + ". " + std::string(sl::toString(data.label).c_str());

objMarkersMsg.markers.push_back(label);
objMarkersMsg.markers.push_back(label);

// visualization_msgs::Marker lines;
// visualization_msgs::Marker label;
Expand Down
Binary file added zed_wrapper/urdf/models/ZED2.stl
Binary file not shown.
4 changes: 2 additions & 2 deletions zed_wrapper/urdf/zed2.urdf
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
<visual>
<origin xyz="0 0 0" rpy="0 0 0"/>
<geometry>
<mesh filename="package://zed_wrapper/urdf/models/ZED.stl" />
<mesh filename="package://zed_wrapper/urdf/models/ZED2.stl" />
</geometry>
<material name="light_grey">
<color rgba="0.8 0.8 0.8 0.8"/>
<color rgba="0.2 0.2 0.2 1.0"/>
</material>
</visual>
</link>
Expand Down