Skip to content

Allow option of inheriting labels and/or annotations #2

@stepro

Description

@stepro

While the default "safe" choice when inheriting an existing configuration is to not inherit labels and annotations, there will clearly be cases where doing so is beneficial. The current behavior is largely there to prevent inheriting configuration for a pod that is selected by a service, because that would cause the kdo pod to be automatically included in load balancing for the service.

It's possible that the current default is wrong. Options are:

  • By default, the --inherit flag means inherit everything, and there's a way to opt out of inheriting labels and annotations (just like there is to not inherit lifecycle and probes);
  • The current default makes sense and inheriting labels and annotations are opt-in;
  • The default is "smart" based on whether what is being inherited is a service or not.

Metadata

Metadata

Assignees

No one assigned

    Labels

    suggestionA suggestion to be discussed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions