-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #34
Conversation
Thanks! Published as 0.9.2 |
It is great that this landed, but there is no CI in this repo, and the changes over in google-auth-library have been quite substantial. It would be good to add a CI, or possibly move the functionality from here to google-auth-library itself. /cc @JustinBeckwith |
I ran locally before publishing. I have an issue to open CI here: #32 But, generally agree: if google-auth-library can make auth easier, like this library, then we should blow this one up. (A discussion on this should probably happen in a different issue, depending on the direction you want to take: "let's move functionality" vs "we need CI") |
I think a CI should exist regardless. There is already an issue open for it: #32 |
This reverts commit aa3b2cf.
@ace-n @ofrobots I had to revert. Would anyone be willing to send another PR, given the changes noted in #35? As I recall, I initially tested against the 1.0.0 pre-release, and things worked fine without changes. It would probably be quicker for someone more familiar with 1.2.0 to take a shot at this. |
We all want CI, we just need to get around to adding it :) RE: solid testing, we could definitely use some real integration tests. |
As title.
The primary motive is to to pull in a
google-auth-library
bugfix for Container Builder, which is integrated in the new release ofgoogle-auth-library
.Note: ideally, this would be a patch or minor version bump. If this change involves a major version bump, we'll have to update any dependents in order to fix the Container Builder issues.