add error reporting

stephenlacy · Aug 5, 2014 · 6ebb29a · 6ebb29a
1 parent 04d269c
commit 6ebb29a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -52,7 +52,7 @@ module.exports = function(opts) {
     try {
       content = JSON.parse(json);
     } catch (e) {
-      return cb(new gutil.PluginError('gulp-bump', 'Problem parsing JSON file ' + file.path));
+      return cb(new gutil.PluginError('gulp-bump', 'Problem parsing JSON file', {fileName: file.path, showStack: true}));
     }
 
     // just set a version to the key
@@ -68,7 +68,7 @@ module.exports = function(opts) {
       content[key] = semver.inc(content[key], type);
     }
     else {
-      return cb(new gutil.PluginError('gulp-bump', 'Detected invalid semver ' + key + ' in file ' + file.path));
+      return cb(new gutil.PluginError('gulp-bump', 'Detected invalid semver ' + key, {fileName: file.path, showStack: false}));
     }
     file.contents = new Buffer(JSON.stringify(content, null, indent || space(json)) + possibleNewline(json));
 

diff --git a/test/main.js b/test/main.js
@@ -128,33 +128,37 @@ describe('gulp-bump', function() {
 
       bumpS.on('error', function(e) {
         should.exist(e);
-        e.name.should.equal('Error');
-        e.message.should.containEql('Detected invalid semver version in file ' + file);
+        e.message.should.equal('Detected invalid semver version');
+        e.fileName.should.containEql(file);
         return done();
       });
       bumpS.write(fakeFile);
       bumpS.end();
     });
 
     it('should fail when not detect a valid semver version and wrong key', function(done) {
+      var file = 'some-dir/dummyfile.js';
       var fakeFile = new gutil.File({
-       contents: new Buffer('{ "version": "0.0.1" }')
+        path: file,
+        contents: new Buffer('{ "version": "0.0.1" }')
       });
 
       var bumpS = bump({key: 'appversion'});
 
       bumpS.on('error', function(e) {
         should.exist(e);
-        e.name.should.equal('Error');
-        e.message.should.containEql('Detected invalid semver appversion in file');
+        e.message.should.containEql('Detected invalid semver appversion');
+        e.fileName.should.containEql(file);
         return done();
       });
       bumpS.write(fakeFile);
       bumpS.end();
     });
 
     it('should fail when supplied with an invalid JSON', function(done) {
+      var file = 'some-dir/dummyfile.js';
       var fakeFile = new gutil.File({
+        path: file,
         contents: new Buffer('{ invalid json oh no!!!}')
       });
 
@@ -164,6 +168,7 @@ describe('gulp-bump', function() {
         should.exist(e);
         e.name.should.equal('Error');
         e.message.should.containEql('Problem parsing JSON file');
+        e.fileName.should.containEql(file);
         return done();
       });
       bumpS.write(fakeFile);