Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

Commit

Permalink
fix(gulp-bump): changed one too many variables
Browse files Browse the repository at this point in the history
On line 74 a variable `value` was introduced that shadowed the old `value` variable. I changed this to use `opts.value` which is incorrect.

This means two things:
If you were to reject this pull request, variable shadowing should be avoided and this should probably be renamed.
If you accept this pull request (I hope you do), variable shadowing is no longer an issue.
  • Loading branch information
Kingdutch committed Feb 27, 2015
1 parent fff003f commit 57c3d15
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ module.exports = function(opts) {
else if (opts.key.indexOf('.') > -1) {
var dot = new Dot();
var value = dot.pick(opts.key, content);
ver = semver.inc(opts.value, opts.type);
ver = semver.inc(value, opts.type);
dot.str(opts.key, ver, content);
}
else {
Expand Down

0 comments on commit 57c3d15

Please sign in to comment.